Re: pfctl_parser.c vs. __KAME

2020-05-03 Thread Alexandr Nedvedicky
Hello JCA, thanks for the pointers. > about this specific piece of code in pfctl, but the "kame hack" is still > here and you really want to double check before removing such chunks in ...so pfctl is the wrong place to start with removal. thanks and regards sashan

Re: pfctl_parser.c vs. __KAME

2020-05-03 Thread Jeremie Courreges-Anglas
On Sun, May 03 2020, Alexandr Nedvedicky wrote: > Hello, Hi Sashan, > the question has popped up while on recent code review of some Solaris > specific > bug fixes: do we still need a code in diff below or is it OK to proceed > and commit the diff? > > The chunk below uses bytes 2 and 3 to deri

pfctl_parser.c vs. __KAME

2020-05-03 Thread Alexandr Nedvedicky
Hello, the question has popped up while on recent code review of some Solaris specific bug fixes: do we still need a code in diff below or is it OK to proceed and commit the diff? The chunk below uses bytes 2 and 3 to derive a scope of link local address. It seems to me those bytes/octets are al