Re: pfctl: use mask parameter and zap bits in host_v4()

2018-08-10 Thread Alexandr Nedvedicky
On Thu, Aug 09, 2018 at 12:01:41PM +0200, Klemens Nanni wrote: > On Wed, Aug 01, 2018 at 01:27:48AM +0200, Klemens Nanni wrote: > > Updated diff bringing this function in line with its counterparts by > > using `mask' the same way. > > > > If a mask was specified, `mask' would always equal to `bit

Re: pfctl: use mask parameter and zap bits in host_v4()

2018-08-09 Thread Klemens Nanni
On Wed, Aug 01, 2018 at 01:27:48AM +0200, Klemens Nanni wrote: > Updated diff bringing this function in line with its counterparts by > using `mask' the same way. > > If a mask was specified, `mask' would always equal to `bits' as returned > by inet_net_pton(), so avoid the duplicate. > > While h

Re: pfctl: use mask parameter and zap bits in host_v4()

2018-07-31 Thread Klemens Nanni
On Mon, Jul 23, 2018 at 11:51:33AM +0200, Klemens Nanni wrote: > Coming from the only caller `host()', the `mask' parameter is -1 iff > `*s' does not contain "/". > > Let's not discard that information and avoid the redundant search; this > makes the `mask' parameter actually being used. Updated d