Re: pf_pull_hdr useless action pointer and fragment logic

Hello, On Mon, Oct 09, 2023 at 08:07:35PM +0200, Alexander Bluhm wrote: > Hi, > > pf_pull_hdr() allows to pass an action pointer parameter as output > value. This is never used, all callers pass a NULL argument. Remove > ACTION_SET() entirely. > > The logic if (fragoff >= len) in pf_pull_hdr()

pf_pull_hdr useless action pointer and fragment logic

Hi, pf_pull_hdr() allows to pass an action pointer parameter as output value. This is never used, all callers pass a NULL argument. Remove ACTION_SET() entirely. The logic if (fragoff >= len) in pf_pull_hdr() looks odd. One is the offset in the IP packet, the latter the length of some header w