Re: pckbc: extend the PS/2 interface tests

2020-09-29 Thread Ulf Brosziewski
t that the lack of support for the AUXECHO command is just a flaw of the firmware, but maybe it's the manufacturer's idea of "phasing out" the legacy interface? Many modern touchpads have dual connections to the system. And if they are recognized and initialized on another bus,

pckbc: extend the PS/2 interface tests

2020-09-13 Thread Ulf Brosziewski
Not all PS/2-like controllers accept the AUXECHO command, and the test that pckbc applies in order to check for the presence of the auxiliary interface may yield false negatives, even on newer hardware (see https://marc.info/?l=openbsd-misc&m=158413132831425&w=2 ). This patch

pckbc(4): tsleep -> tsleep_nsec(9)

2019-11-22 Thread Scott Cheloha
ok? Index: pckbc.c === RCS file: /cvs/src/sys/dev/ic/pckbc.c,v retrieving revision 1.52 diff -u -p -r1.52 pckbc.c --- pckbc.c 3 Jun 2019 16:46:49 - 1.52 +++ pckbc.c 23 Nov 2019 00:27:11 - @@ -931,7 +931,7 @@ pckb

Re: pckbc(4) diff

2019-01-29 Thread Raphael Graf
On Mon, Jan 28, 2019 at 08:14:09PM +0100, Marcus Glocker wrote: > On some machines when the pckbc(4) keyboard controller driver attaches > to the console, it's possible to inject characters by moving your mouse > in to the keyboard channel. When injecting enough noise the keyboa

pckbc(4) diff

2019-01-28 Thread Marcus Glocker
On some machines when the pckbc(4) keyboard controller driver attaches to the console, it's possible to inject characters by moving your mouse in to the keyboard channel. When injecting enough noise the keyboard will stop operating at some point. A nice way to test this, e.g. on my ThinkPa

Re: pckbc

2015-05-04 Thread Alexandre Ratchov
On Mon, May 04, 2015 at 08:47:29PM +0500, Alexandr Shadchin wrote: > Less magic number > > For PS/2 - status byte - bit 5: > The bit is '1' if the data on input port 60h came from the AUX port, or '0' if > the data came from the keyboard or from the keyboard controller itself. > > KBS_TERR (kbd t

pckbc

2015-05-04 Thread Alexandr Shadchin
Less magic number For PS/2 - status byte - bit 5: The bit is '1' if the data on input port 60h came from the AUX port, or '0' if the data came from the keyboard or from the keyboard controller itself. KBS_TERR (kbd transmission error) was valid for AT-mode, but not for PS/2-mode. Comment ? OK ?

Re: sys/dev/pckbc/pms.c diff

2013-07-01 Thread Martin Pieuchot
So this change only makes the code harder to understand as it suggests there's more than two protocols supported by this function. > > Index: pms.c > > === > > RCS file: /cvs/src/sys/dev/pckbc/pms.c,v > >

sys/dev/pckbc/pms.c diff

2013-06-28 Thread David Hill
in pms_proc_mouse, wsmouse_input is called with an uninitialized 'dz' variable if the sc->protocol->type is not PMS_STANDARD or PMS_INTELLI. Index: pms.c === RCS file: /cvs/src/sys/dev/pckbc/pms.c,v retrieving revis

Re: cleanup directory sys/dev/pckbc

2010-12-26 Thread Kenneth R Westerback
On Sat, Dec 25, 2010 at 10:57:40PM +0500, Alexandr Shadchin wrote: > > remove file sys/dev/pckbc/Makefile > This file is accidentally imported from NetBSD, and probably never used. > > -- > Alexandr Shadchin &g

cleanup directory sys/dev/pckbc

2010-12-25 Thread Alexandr Shadchin
remove file sys/dev/pckbc/Makefile This file is accidentally imported from NetBSD, and probably never used. -- Alexandr Shadchin Index: Makefile === RCS file: Makefile diff -N Makefile --- Makefile13 Nov 2000 20:12:34 -

try to improve pckbc emulation detection

2010-08-05 Thread Miod Vallat
The current heuristic to try and detect that the pckbc device we talk to is actually an USB controller in legacy mode fail on a few systems, especially some Toshiba laptops. I have noticed that, when the code decides not to attach pckbd, a mouse device will attach anyway. On an USB emulation