Re: patching use-after-free and innocent memory leak in pfctl_optimzie.c

2017-11-25 Thread Alexandr Nedvedicky
On Fri, Nov 24, 2017 at 07:22:58PM +0100, Alexander Bluhm wrote: > On Fri, Nov 24, 2017 at 01:11:08PM +0100, Alexandr Nedvedicky wrote: > > the patch below is part of larger diff [1] I've sent earlier. Leonardo > > seen a > > pfctl.core, when pfctl_optimize failed to create a radix table. The use

Re: patching use-after-free and innocent memory leak in pfctl_optimzie.c

2017-11-24 Thread Alexander Bluhm
On Fri, Nov 24, 2017 at 01:11:08PM +0100, Alexandr Nedvedicky wrote: > the patch below is part of larger diff [1] I've sent earlier. Leonardo seen a > pfctl.core, when pfctl_optimize failed to create a radix table. The use after > free happens in superblock_free() at 1621: I have seen exactly the

patching use-after-free and innocent memory leak in pfctl_optimzie.c

2017-11-24 Thread Alexandr Nedvedicky
Hello, the patch below is part of larger diff [1] I've sent earlier. Leonardo seen a pfctl.core, when pfctl_optimize failed to create a radix table. The use after free happens in superblock_free() at 1621: 1618 while ((por = TAILQ_FIRST(&block->sb_rules))) { 1619 TAILQ_RE