Re: patch: native ed support

2015-10-13 Thread Tobias Stoeckmann
On Tue, Oct 13, 2015 at 06:43:31PM +0200, Tobias Stoeckmann wrote: > - Check for our new /.// substitution expression > - Be more restrictive about command parsing, so we do not > allow commands like "10insert" instead of "10i". And now, fix regression which I introduced with that diff, of cours

Re: patch: native ed support

2015-10-13 Thread Tobias Stoeckmann
On Mon, Oct 12, 2015 at 12:01:49PM -0600, Todd C. Miller wrote: > I think this is the correct approach. I've only taken a brief look > so far but I think you should make write_lines() static in its > declaration to match the prototype. Thanks for pointing this out. Updated diff below: - Make wri

Re: patch: native ed support

2015-10-12 Thread Todd C. Miller
I think this is the correct approach. I've only taken a brief look so far but I think you should make write_lines() static in its declaration to match the prototype. - todd

patch: native ed support

2015-10-11 Thread Tobias Stoeckmann
Currently, patch calls /bin/ed to support ed-formatted diffs, which means that patch needs to pledge proc and exec. As discussed, it would be a huge benefit if we can remove that. Our patch implementation and GNU patch are already very restrictive in which patch lines are sent to ed, so don't expe