Re: once rules fix

2019-03-05 Thread petr . hoffmann
Klemens Nanni writes: > Thanks! Diff makes sense, see comments inline. I confirm that this > restores intended behaviour and regress is fine as well. > > With those addressed OK kn; or I take care of it after getting an OK. > sashan? Thanks for pointing to the details. Fixed now: diff --git a

Re: once rules fix

2019-03-05 Thread Alexandr Nedvedicky
Hello Klemens, On Tue, Mar 05, 2019 at 04:47:33PM +0100, Klemens Nanni wrote: > Thanks! Diff makes sense, see comments inline. I confirm that this > restores intended behaviour and regress is fine as well. > > With those addressed OK kn; or I take care of it after getting an OK. > sashan?

Re: once rules fix

2019-03-05 Thread Klemens Nanni
Thanks! Diff makes sense, see comments inline. I confirm that this restores intended behaviour and regress is fine as well. With those addressed OK kn; or I take care of it after getting an OK. sashan? On Tue, Mar 05, 2019 at 04:31:40AM -0800, petr.hoffm...@oracle.com wrote: > @@ -913,7 +913,33

Re: once rules fix

2019-03-05 Thread petr . hoffmann
Sorry, my MUA replaced tabs with spaces in the patch I sent previously. Find the correct one below: diff --git a/sbin/pfctl/parse.y b/sbin/pfctl/parse.y index e8dd97f6222..e55b2893069 100644 --- a/sbin/pfctl/parse.y +++ b/sbin/pfctl/parse.y @@ -354,7 +354,7 @@ struct pfctl_watermarks syncooki

once rules fix

2019-03-03 Thread Petr Hoffmann
Hi, I noticed that pfctl says 'once' can be used only with pass/block rules, but it is not true - it can't for block but can for anchor rules: --8<--- # echo 'block once' | pfctl -f - stdin:1: 'once' only applies to pass/block rules pfc