Re: off by one ksh

2019-01-14 Thread Ingo Schwarze
Hi Ted, Ted Unangst wrote on Sun, Jan 13, 2019 at 08:23:01PM -0500: > Ingo Schwarze wrote: >> Feel free to either commit the complete patch below or commit >> only your part and optionally OK one, two, or three of my additional >> changes. > These look ok with one comment. Committed, thanks for

Re: off by one ksh

2019-01-13 Thread Ted Unangst
Ingo Schwarze wrote: > Feel free to either commit the complete patch below or commit > only your part and optionally OK one, two, or three of my additional > changes. These look ok with one comment. > @@ -141,8 +141,11 @@ mpset(char *mptoparse) > mmsg = strchr(mpath, '?'); >

Re: off by one ksh

2019-01-13 Thread Ingo Schwarze
Hi Ted, Ted Unangst wrote on Sun, Jan 13, 2019 at 03:48:05AM -0500: > By inspection, it appears possible this access will underrun if the > first character is a %. OK schwarze@ That said, i see three more buglets here. 1. If the mailbox filename ends in a percent sign (not saying that is

off by one ksh

2019-01-13 Thread Ted Unangst
By inspection, it appears possible this access will underrun if the first character is a %. Index: mail.c === RCS file: /cvs/src/bin/ksh/mail.c,v retrieving revision 1.25 diff -u -p -r1.25 mail.c --- mail.c 7 Jan 2019 20:50:43 -