Re: no seqpacket in nfs

2017-08-14 Thread Alexander Bluhm
On Sun, Aug 13, 2017 at 11:03:02PM -0400, Ted Unangst wrote: > here's a new version that pulls the check higher. OK bluhm@ > - if (so->so_type == SOCK_SEQPACKET) > - flags = MSG_EOR; > - else > - flags = 0; > + flags = 0; > > error = sosend(so, sendnam,

Re: no seqpacket in nfs

2017-08-13 Thread Ted Unangst
Alexander Bluhm wrote: > On Sun, Aug 13, 2017 at 05:20:05PM -0400, Ted Unangst wrote: > > - if (nmp->nm_sotype != SOCK_STREAM) > > - panic("nfscon sotype"); > > + } else { > > + panic("nfscon sotype"); > > This panic can be reached from user land with a mani

Re: no seqpacket in nfs

2017-08-13 Thread Alexander Bluhm
On Sun, Aug 13, 2017 at 05:20:05PM -0400, Ted Unangst wrote: > - if (nmp->nm_sotype != SOCK_STREAM) > - panic("nfscon sotype"); > + } else { > + panic("nfscon sotype"); This panic can be reached from user land with a manipulated mount_nfs program. T

no seqpacket in nfs

2017-08-13 Thread Ted Unangst
discovered this looking at something else. we don't and won't support seqpacket for nfs sockets. perhaps a bit more can be cleaned up too. i don't think we support any stream sockets that don't require connections, etc... Index: nfs_socket.c ==