Re: nfs mp vnode list remove safe

2020-01-14 Thread Alexander Bluhm
On Tue, Jan 14, 2020 at 01:32:50PM -0500, Ted Unangst wrote: > Alexander Bluhm wrote: > > loop: > > - TAILQ_FOREACH_SAFE(vp, &mp->mnt_vnodelist, v_mntvnodes, nvp) { > > + TAILQ_FOREACH(vp, &mp->mnt_vnodelist, v_mntvnodes) { > > if (vp->v_mount != mp) /* Paranoia */ > >

Re: nfs mp vnode list remove safe

2020-01-14 Thread Ted Unangst
Alexander Bluhm wrote: > Hi, > > There is no remove and no sleep in this loop. So _SAFE is unnecessary. > > ok? sure, with one bonus note. > > bluhm > > Index: nfs/nfs_subs.c > === > RCS file: /data/mirror/openbsd/cvs/src/sys/nf

nfs mp vnode list remove safe

2020-01-14 Thread Alexander Bluhm
Hi, There is no remove and no sleep in this loop. So _SAFE is unnecessary. ok? bluhm Index: nfs/nfs_subs.c === RCS file: /data/mirror/openbsd/cvs/src/sys/nfs/nfs_subs.c,v retrieving revision 1.141 diff -u -p -r1.141 nfs_subs.c ---