Re: nfe(4) diff for promisc/multicast changes needs testing.

2009-08-13 Thread Brad
On Thursday 30 July 2009 05:00:31 Brad wrote: > The following diff rewrites parts of the code for promiscuous mode > and multicast handling for the nfe(4) driver. Please test promisc > mode and multicast mode of operation with any nfe(4) adapters. > > Please provide a dmesg. I'm still looking for

Re: nfe(4) diff for promisc/multicast changes needs testing.

2009-07-30 Thread damien . bergamini
OK, thanks for the explanation. It wasn't obvious from just reading the diff. Damien | On Thursday 30 July 2009 05:12:50 damien.bergam...@free.fr wrote: | > Except "rewriting parts of the code", what does this diff do? | > Does it fix an existing bug? | > Or is it just rewriting for the sake of

Re: nfe(4) diff for promisc/multicast changes needs testing.

2009-07-30 Thread Brad
On Thursday 30 July 2009 05:12:50 damien.bergam...@free.fr wrote: > Except "rewriting parts of the code", what does this diff do? > Does it fix an existing bug? > Or is it just rewriting for the sake of rewriting? The current ALLMULTI flag handling is a bug. Drivers should now be checking ac->ac_

Re: nfe(4) diff for promisc/multicast changes needs testing.

2009-07-30 Thread damien . bergamini
Except "rewriting parts of the code", what does this diff do? Does it fix an existing bug? Or is it just rewriting for the sake of rewriting? Damien | The following diff rewrites parts of the code for promiscuous mode | and multicast handling for the nfe(4) driver. Please test promisc | mode and

nfe(4) diff for promisc/multicast changes needs testing.

2009-07-30 Thread Brad
The following diff rewrites parts of the code for promiscuous mode and multicast handling for the nfe(4) driver. Please test promisc mode and multicast mode of operation with any nfe(4) adapters. Please provide a dmesg. Index: if_nfe.c