Re: nd6 remove kernel lock

2023-05-13 Thread Alexander Bluhm
On Fri, May 12, 2023 at 11:43:42AM +, Klemens Nanni wrote: > On Fri, May 12, 2023 at 12:18:12AM +0200, Alexander Bluhm wrote: > > Access rt_llinfo either with nd6 mutex or exclusive netlock. > > Can you leave a comment at the read-only ioctl wrt. exclusive net lock? Even better. nd6_lookup()

Re: nd6 remove kernel lock

2023-05-12 Thread Vitaliy Makkoveev
> On 12 May 2023, at 15:07, Alexander Bluhm wrote: > > On Fri, May 12, 2023 at 11:43:42AM +, Klemens Nanni wrote: >>> Access rt_llinfo and check for NULL without checking RTF_LLINFO >>> flag before. They are changed togehter with the arp or nd6 mutex. >> >> It is the same change, but I'd co

Re: nd6 remove kernel lock

2023-05-12 Thread Alexander Bluhm
On Fri, May 12, 2023 at 11:43:42AM +, Klemens Nanni wrote: > > Access rt_llinfo and check for NULL without checking RTF_LLINFO > > flag before. They are changed togehter with the arp or nd6 mutex. > > It is the same change, but I'd commit ARP separately (you don't change > any locking semanti

Re: nd6 remove kernel lock

2023-05-12 Thread Klemens Nanni
On Fri, May 12, 2023 at 12:18:12AM +0200, Alexander Bluhm wrote: > Hi, > > I would like to remove the kernel lock from nd6 resolve and use nd6 > mutex instead. > > Access rt_llinfo and check for NULL without checking RTF_LLINFO > flag before. They are changed togehter with the arp or nd6 mutex.

nd6 remove kernel lock

2023-05-11 Thread Alexander Bluhm
Hi, I would like to remove the kernel lock from nd6 resolve and use nd6 mutex instead. Access rt_llinfo and check for NULL without checking RTF_LLINFO flag before. They are changed togehter with the arp or nd6 mutex. Access rt_llinfo either with nd6 mutex or exclusive netlock. Remove some need