Re: more clang libc fun

2016-09-10 Thread Philip Guenther
On Sat, 10 Sep 2016, Mark Kettenis wrote: > From: Philip Guenther ... > > Also interesting that it generates memmove() calls. Wonder where it > > ended up doing that. > > Well, clang actually calls the functions with their standard name even > for the cases where we explicitly call those funct

Re: more clang libc fun

2016-09-10 Thread Mark Kettenis
> Date: Sat, 10 Sep 2016 13:55:15 -0700 > From: Philip Guenther > > On Sat, 10 Sep 2016, Mark Kettenis wrote: > > Thanks. Now the only issue seems to be: > > > > barber$ check_sym > > /usr/lib/libc.so.89.1 --> obj/libc.so.89.1 > > Dynamic export changes: > > PLT added: > > __stack_sma

Re: more clang libc fun

2016-09-10 Thread Philip Guenther
On Sat, 10 Sep 2016, Mark Kettenis wrote: > Thanks. Now the only issue seems to be: > > barber$ check_sym > /usr/lib/libc.so.89.1 --> obj/libc.so.89.1 > Dynamic export changes: > PLT added: > __stack_smash_handler > memcpy > memmove > memset > > Not sure how to

Re: more clang libc fun

2016-09-10 Thread Mark Kettenis
> Date: Sat, 10 Sep 2016 13:33:58 -0700 > From: Philip Guenther > > On Sat, 10 Sep 2016, Mark Kettenis wrote: > > Seems the clang assembler ignores a .weak directive before the symbol is > > defined. > > > > ok? > > certainly. Thanks. Now the only issue seems to be: barber$ check_sym /usr

Re: more clang libc fun

2016-09-10 Thread Philip Guenther
On Sat, 10 Sep 2016, Mark Kettenis wrote: > Seems the clang assembler ignores a .weak directive before the symbol is > defined. > > ok? certainly.

more clang libc fun

2016-09-10 Thread Mark Kettenis
Seems the clang assembler ignores a .weak directive before the symbol is defined. ok? Index: lib/libc/arch/amd64/sys/brk.S === RCS file: /cvs/src/lib/libc/arch/amd64/sys/brk.S,v retrieving revision 1.8 diff -u -p -r1.8 brk.S --- lib