Re: merge vlan and carp input back into ether_input

2018-01-14 Thread Florian Riehm
On 01/11/18 14:51, Martin Pieuchot wrote: On 11/01/18(Thu) 21:59, David Gwynne wrote: [...] when you say i break carp balancing, are you talking about the removal of the PACKET_TAG_CARP_BAL_IP tagging? PACKET_TAG_CARP_BAL_IP is only used in carp_lsdrop to clear the M_MCAST flag on the mbuf. M_

Re: merge vlan and carp input back into ether_input

2018-01-11 Thread David Gwynne
On Thu, Jan 11, 2018 at 02:51:40PM +0100, Martin Pieuchot wrote: > On 11/01/18(Thu) 21:59, David Gwynne wrote: > > [...] > > when you say i break carp balancing, are you talking about the removal of > > the PACKET_TAG_CARP_BAL_IP tagging? PACKET_TAG_CARP_BAL_IP is only used in > > carp_lsdrop to

Re: merge vlan and carp input back into ether_input

2018-01-11 Thread Martin Pieuchot
On 11/01/18(Thu) 21:59, David Gwynne wrote: > [...] > when you say i break carp balancing, are you talking about the removal of the > PACKET_TAG_CARP_BAL_IP tagging? PACKET_TAG_CARP_BAL_IP is only used in > carp_lsdrop to clear the M_MCAST flag on the mbuf. M_MCAST wont be set on > packets dest

Re: merge vlan and carp input back into ether_input

2018-01-11 Thread David Gwynne
> On 11 Jan 2018, at 8:58 pm, Martin Pieuchot wrote: > > On 11/01/18(Thu) 11:50, David Gwynne wrote: >> while we were working on making the various pseudo interfaces you >> stack on top of ethernet mpsafe, we split their input processing >> off so they could be attacked one by one. they're all

Re: merge vlan and carp input back into ether_input

2018-01-11 Thread Martin Pieuchot
On 11/01/18(Thu) 11:50, David Gwynne wrote: > while we were working on making the various pseudo interfaces you > stack on top of ethernet mpsafe, we split their input processing > off so they could be attacked one by one. they're all mpsafe now, > so this separation is not strictly necessary anymo

merge vlan and carp input back into ether_input

2018-01-10 Thread David Gwynne
while we were working on making the various pseudo interfaces you stack on top of ethernet mpsafe, we split their input processing off so they could be attacked one by one. they're all mpsafe now, so this separation is not strictly necessary anymore. this moves carp and vlan input back into ether_