On Fri, Jul 13, 2012 at 03:16:27AM -0600, Theo de Raadt wrote:
> + printf(msg);
>
> This really should be
>
> printf("%s", msg);
>
> To avoid format string problems.
>
> Yes, you say you are completely in control of the string however
> someone could reuse this workq handler f
+ printf(msg);
This really should be
printf("%s", msg);
To avoid format string problems.
Yes, you say you are completely in control of the string however
someone could reuse this workq handler for some other purpose later.
On Fri, Jul 13, 2012 at 10:54:23AM +0200, Mark Kettenis wrote:
> But doing the printf from spltty() doesn't make an awful lot of sense.
> We already protect printf(9) by a mutex at IPL_HIGH.
Correct, I hadn't seen that, thanks!
> Also...
> > +/* Work queue task that prints a received frame. A
> Date: Fri, 13 Jul 2012 10:42:02 +0200
> From: Stefan Sperling
>
> On Thu, Jul 12, 2012 at 05:51:32PM +0200, Stefan Sperling wrote:
> > Running "ifconfig ral0 debug down up" can leave slow systems, such
> > as edd@'s soekris, with an unusable wireless interface until reboot.
> >
> > The net80
On Thu, Jul 12, 2012 at 05:51:32PM +0200, Stefan Sperling wrote:
> Running "ifconfig ral0 debug down up" can leave slow systems, such
> as edd@'s soekris, with an unusable wireless interface until reboot.
>
> The net80211 layer will run a scan when the interface comes up.
> The scan hops from ch
Running "ifconfig ral0 debug down up" can leave slow systems, such
as edd@'s soekris, with an unusable wireless interface until reboot.
The net80211 layer will run a scan when the interface comes up.
The scan hops from channel to channel every 200msec. This hopping is
controlled via a timeout th
