Re: login_yubikey case-insensitive hex decoding

2012-11-23 Thread Philip Guenther
On Fri, 23 Nov 2012, Alexander Hall wrote: > On 11/23/12 02:17, Philip Guenther wrote: ... > > The argument to tolower() must be a value in the range [EOF, > > 0..UCHAR_MAX]. When taking characters from a char * string, you need > > to cast the value to (unsigned char), ala > > tolower((un

Re: login_yubikey case-insensitive hex decoding

2012-11-23 Thread Alexander Hall
On 11/23/12 02:17, Philip Guenther wrote: > On Thu, Nov 22, 2012 at 5:28 PM, Alexander Hall wrote: >> The corresponding part in yubikey_hex_decode is for consistency and, >> IMO, sanity, allowing mixed case hex strings, e.g. /var/db/yubikey/*. >> >> Comments? OK? (Don't mess with the from-upstream

Re: login_yubikey case-insensitive hex decoding

2012-11-22 Thread Philip Guenther
On Thu, Nov 22, 2012 at 5:28 PM, Alexander Hall wrote: > The corresponding part in yubikey_hex_decode is for consistency and, > IMO, sanity, allowing mixed case hex strings, e.g. /var/db/yubikey/*. > > Comments? OK? (Don't mess with the from-upstream-derived yubikey.c?) ... > - if ((

login_yubikey case-insensitive hex decoding

2012-11-22 Thread Alexander Hall
Cheers, SHIFT or CAPS LOCK (on any keyboard) screws up the parsing of the yubikey OTP. So make that parsing case-insensitive. The corresponding part in yubikey_hex_decode is for consistency and, IMO, sanity, allowing mixed case hex strings, e.g. /var/db/yubikey/*. Comments? OK? (Don't mess with