On Mon, Sep 19, 2016 at 5:41 AM, Martin Natano wrote:
> Two more loops that can be converted to arc4random_buf(). Ok?
> [...]
> + arc4random_buf(x11_fake_data, data_len);
> for (i = 0; i < data_len; i++) {
>
I'd put that below the for loop so it matches the order of
Two more loops that can be converted to arc4random_buf(). Ok?
natano
Index: channels.c
===
RCS file: /cvs/src/usr.bin/ssh/channels.c,v
retrieving revision 1.352
diff -u -p -r1.352 channels.c
--- channels.c 12 Sep 2016 01:22:38 -000
Ted Unangst wrote:
> no change, but makes the code a little shorter.
while here, another similar spot.
Index: clientloop.c
===
RCS file: /cvs/src/usr.bin/ssh/clientloop.c,v
retrieving revision 1.287
diff -u -p -r1.287 clientloop.c
-
On Fri, Sep 16, 2016 at 09:19:40PM -0400, Ted Unangst wrote:
> no change, but makes the code a little shorter.
Reads fine to me. arc4random() is already used in other places in ssh,
so this shouldn't be an issue for portable.
>
>
> Index: clientloop.c
>
no change, but makes the code a little shorter.
Index: clientloop.c
===
RCS file: /cvs/src/usr.bin/ssh/clientloop.c,v
retrieving revision 1.287
diff -u -p -r1.287 clientloop.c
--- clientloop.c12 Sep 2016 01:22:38 - 1
