On Tue, Apr 30, 2019 at 07:13:55PM +0200, Jeremie Courreges-Anglas wrote:
> > So the diff below removes the fallback path and all associated code and
> > variables.
>
> > I have left out some minor cleanups for now to ease reviews.
>
> Here's a diff that amends the signature of gettime() and make
Looks good to me.
On Tue, 30 Apr 2019, 19:32 Jeremie Courreges-Anglas, wrote:
> On Tue, Apr 30 2019, Nicholas Marriott
> wrote:
> > Oh, event_err typically uses __func__ so I would do that here too.
>
> Indeed my proposal doesn't match the pattern used here.
> Does this look better?
>
>
Jeremie Courreges-Anglas wrote:
> So the diff below removes the fallback path and all associated code and
> variables. I have left out some minor cleanups for now to ease reviews.
makes sense to me.
On Tue, Apr 30 2019, Nicholas Marriott wrote:
> Oh, event_err typically uses __func__ so I would do that here too.
Indeed my proposal doesn't match the pattern used here.
Does this look better?
if (clock_gettime(CLOCK_MONOTONIC, &ts) == -1)
event_err(1, "%s: clock_gettime
Oh, event_err typically uses __func__ so I would do that here too.
On Tue, Apr 30, 2019 at 06:48:13PM +0100, Nicholas Marriott wrote:
> ok for both
>
>
> On Tue, Apr 30, 2019 at 07:13:55PM +0200, Jeremie Courreges-Anglas wrote:
> > On Tue, Apr 30 2019, Jeremie Courreges-Anglas wrote:
> > > lib
ok for both
On Tue, Apr 30, 2019 at 07:13:55PM +0200, Jeremie Courreges-Anglas wrote:
> On Tue, Apr 30 2019, Jeremie Courreges-Anglas wrote:
> > libevent contains a fallback path in case clock_gettime(CLOCK_MONOTONIC)
> > fails. The fallback path tries to cope with time going backwards and
> >
On Tue, Apr 30 2019, Jeremie Courreges-Anglas wrote:
> libevent contains a fallback path in case clock_gettime(CLOCK_MONOTONIC)
> fails. The fallback path tries to cope with time going backwards and
> reaches into the timeheap internals, as noticed by Tobias in
>
> https://marc.info/?l=openbsd-
libevent contains a fallback path in case clock_gettime(CLOCK_MONOTONIC)
fails. The fallback path tries to cope with time going backwards and
reaches into the timeheap internals, as noticed by Tobias in
https://marc.info/?l=openbsd-tech&m=155595247719664&w=2
I doubt that we care about this
