Re: libcrypto: fix BN_mod_word bug

2016-07-04 Thread Bob Beck
ok beck@, with an appropriate commit message On Mon, Jul 04, 2016 at 06:59:28PM -0500, Brent Cook wrote: > I copied some of the commit text here from BoringSSL, but it's wrong for > LibreSSL it seems. > > BN_ULLONG is not defined on all 64-bit systems as far as I can tell. So, this > fix is mo

Re: libcrypto: fix BN_mod_word bug

2016-07-04 Thread Brent Cook
I copied some of the commit text here from BoringSSL, but it's wrong for LibreSSL it seems. BN_ULLONG is not defined on all 64-bit systems as far as I can tell. So, this fix is more widely applicable than Win64 for LibreSSL. Any comments? - Brent > On Jun 30, 2016, at 8:40 AM, Brent Cook wr

libcrypto: fix BN_mod_word bug

2016-06-30 Thread Brent Cook
On systems where we do not have BN_ULLONG (notably Win64), BN_mod_word() can return incorrect results if the supplied modulus is too big. Note now that BN_mod_word may fail, like BN_div_word. Handle this properly and document in the man page. Thanks to Brian Smith for pointing out these fixes fro