Re: libX11 patch for X*IfEvent() API issues, take #2

2022-11-14 Thread Walter Alejandro Iglesias
Hi Matthiew, On Nov 11 2022, Walter Alejandro Iglesias wrote: > On Nov 11 2022, Matthieu Herrb wrote: > > On Fri, Nov 11, 2022 at 03:17:21PM +0100, Walter Alejandro Iglesias wrote: > > > On Nov 11 2022, Matthieu Herrb wrote: > > > > Hi, > > > > > > > > So the patch provided by Adam Jackson upstre

Re: libX11 patch for X*IfEvent() API issues, take #2

2022-11-11 Thread Walter Alejandro Iglesias
On Nov 11 2022, Matthieu Herrb wrote: > On Fri, Nov 11, 2022 at 03:17:21PM +0100, Walter Alejandro Iglesias wrote: > > On Nov 11 2022, Matthieu Herrb wrote: > > > Hi, > > > > > > So the patch provided by Adam Jackson upstreams is completely buggy. > > > > > > - the logic to setup the new locking

Re: libX11 patch for X*IfEvent() API issues, take #2

2022-11-11 Thread Matthieu Herrb
On Fri, Nov 11, 2022 at 03:17:21PM +0100, Walter Alejandro Iglesias wrote: > On Nov 11 2022, Matthieu Herrb wrote: > > Hi, > > > > So the patch provided by Adam Jackson upstreams is completely buggy. > > > > - the logic to setup the new locking function was busted > > - I've observed cases where

Re: libX11 patch for X*IfEvent() API issues, take #2

2022-11-11 Thread Matthieu Herrb
On Fri, Nov 11, 2022 at 03:17:21PM +0100, Walter Alejandro Iglesias wrote: > On Nov 11 2022, Matthieu Herrb wrote: > > Hi, > > > > So the patch provided by Adam Jackson upstreams is completely buggy. > > > > - the logic to setup the new locking function was busted > > - I've observed cases where

Re: libX11 patch for X*IfEvent() API issues, take #2

2022-11-11 Thread Walter Alejandro Iglesias
On Nov 11 2022, Matthieu Herrb wrote: > Hi, > > So the patch provided by Adam Jackson upstreams is completely buggy. > > - the logic to setup the new locking function was busted > - I've observed cases where even the XGetIfEvent() function gets > re-rentered. So the flags does in fact need to

libX11 patch for X*IfEvent() API issues, take #2

2022-11-11 Thread Matthieu Herrb
Hi, So the patch provided by Adam Jackson upstreams is completely buggy. - the logic to setup the new locking function was busted - I've observed cases where even the XGetIfEvent() function gets re-rentered. So the flags does in fact need to be a counter. New patch which works for me with fvw

Re: libX11 patch for X*IfEvent() API issues

2022-11-02 Thread Walter Alejandro Iglesias
Hello Matthieu, On Nov 01 2022, Matthieu Herrb wrote: > Hi, > > here's a libX11 patch that needs some wide testing, especially from > people who have experienced issues with various applications (fvwm[23] > from ports, Motif applications with Drag'n'Drop,..) with the upgrade > to libX11 1.8.1, be

libX11 patch for X*IfEvent() API issues

2022-11-01 Thread Matthieu Herrb
Hi, here's a libX11 patch that needs some wide testing, especially from people who have experienced issues with various applications (fvwm[23] from ports, Motif applications with Drag'n'Drop,..) with the upgrade to libX11 1.8.1, before I added the --disable-thread-safety-constructor option to the