Re: less ok cron

2015-01-23 Thread Todd C. Miller
On Thu, 22 Jan 2015 21:45:02 -0500, Ted Unangst wrote: > On Thu, Jan 22, 2015 at 20:16, Ted Unangst wrote: > > > This diff is mechanical in nature. Later I will fix the bugs it reveals: > > > > - while ((status = load_env(envstr, file)) >= OK) { > > + while ((status = load_env(envstr

Re: less ok cron

2015-01-22 Thread Ted Unangst
On Thu, Jan 22, 2015 at 20:16, Ted Unangst wrote: > This diff is mechanical in nature. Later I will fix the bugs it reveals: > > - while ((status = load_env(envstr, file)) >= OK) { > + while ((status = load_env(envstr, file)) >= 0) { > switch (status) { > - case ERR: > +

Re: less ok cron

2015-01-22 Thread Rick Ballard
I think you mean 0 On Thu, Jan 22, 2015 at 9:19 PM, Theo de Raadt wrote: > OK > > -- Rick Ballard Dartmouth,Nova Scotia, Canada

Re: less ok cron

2015-01-22 Thread Theo de Raadt
OK

less ok cron

2015-01-22 Thread Ted Unangst
remove the OK and ERR macros. They obfuscate the code and don't help legibility. (unix system calls use 0 for ok, but hundreds of other projects use 1 to indicate success.) Despite the name, many system calls (e.g., open) also return not OK values for success. It also cleans up some weird code lik