Re: ldomctl: Add -c to start for automatic console connect

2020-01-17 Thread Klemens Nanni
On Fri, Jan 17, 2020 at 03:53:23PM +0100, Mark Kettenis wrote: > Might make sense, especially if it is fast enough to catch the ddb output. Simple tests did catch some output, but it is racy. > ok kettenis@ Committed, thanks.

Re: ldomctl: Add -c to start for automatic console connect

2020-01-17 Thread Mark Kettenis
> Date: Fri, 17 Jan 2020 12:23:04 +0100 > From: Klemens Nanni > Cc: tech > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > > On Fri, Jan 17, 2020 at 10:01:08AM +, Andrew Grillet wrote: > > Is there any possibility that the same -c option could be added to > > > ldo

Re: ldomctl: Add -c to start for automatic console connect

2020-01-17 Thread Klemens Nanni
On Fri, Jan 17, 2020 at 10:01:08AM +, Andrew Grillet wrote: > Is there any possibility that the same -c option could be added to > > ldomctl panic -c > It would be very useful. I don't really use panic but if kettenis is fine with adding -c there as well, why not. The code repitition in ldomc

Re: ldomctl: Add -c to start for automatic console connect

2020-01-17 Thread Andrew Grillet
Is there any possibility that the same -c option could be added to > ldomctl panic -c It would be very useful. On Thu, 16 Jan 2020 at 14:31, Klemens Nanni wrote: > On Thu, Jan 16, 2020 at 02:27:42PM +0100, Klemens Nanni wrote: > > Just like vmctl(8), this implements the little convenience for

Re: ldomctl: Add -c to start for automatic console connect

2020-01-16 Thread Mark Kettenis
> Date: Thu, 16 Jan 2020 15:26:13 +0100 > From: Klemens Nanni > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > > On Thu, Jan 16, 2020 at 02:27:42PM +0100, Klemens Nanni wrote: > > Just like vmctl(8), this implements the little convenience for ldomctl: > > > > $ do

Re: ldomctl: Add -c to start for automatic console connect

2020-01-16 Thread Klemens Nanni
On Thu, Jan 16, 2020 at 02:27:42PM +0100, Klemens Nanni wrote: > Just like vmctl(8), this implements the little convenience for ldomctl: > > $ doas ./obj/ldomctl start -c guest4 > Connected to /dev/ttyV3 (speed 9600) > ... > > To avoid duplicate code, I moved the now common

Re: ldomctl: Add -c to start for automatic console connect

2020-01-16 Thread Ingo Schwarze
Hi Mark and Klemens, Mark Kettenis wrote on Thu, Jan 16, 2020 at 02:46:02PM +0100: > I suppose this is fine since vmctl(8) has the same option. > > However the way you change the usage output isn't quite right. > Maybe "start" should go on a line of its own then. That sounds reasonable. > But

Re: ldomctl: Add -c to start for automatic console connect

2020-01-16 Thread Klemens Nanni
On Thu, Jan 16, 2020 at 02:46:02PM +0100, Mark Kettenis wrote: > However the way you change the usage output isn't quite right. Maybe > "start" should go on a line of its own then. But then we're back to > the discussion that too many lines make the usage output useless. You mean because the flag

Re: ldomctl: Add -c to start for automatic console connect

2020-01-16 Thread Mark Kettenis
> Date: Thu, 16 Jan 2020 14:27:42 +0100 > From: Klemens Nanni > > Just like vmctl(8), this implements the little convenience for ldomctl: > > $ doas ./obj/ldomctl start -c guest4 > Connected to /dev/ttyV3 (speed 9600) > ... > > To avoid duplicate code, I moved the now comm

ldomctl: Add -c to start for automatic console connect

2020-01-16 Thread Klemens Nanni
Just like vmctl(8), this implements the little convenience for ldomctl: $ doas ./obj/ldomctl start -c guest4 Connected to /dev/ttyV3 (speed 9600) ... To avoid duplicate code, I moved the now common exec routine into console_exec() which is used by guest_console() and g