Re: ksh: Use typedef for function pointer

2020-05-08 Thread Michael Forney
On 2020-05-08, Jeremie Courreges-Anglas wrote: > Out of curiosity, do you run (o)ksh on machines where this matters? Yes, my C compiler (https://sr.ht/~mcf/cproc/) follows the standard fairly strictly. > Aside from the increased portability, the code doesn't look worse, and > fewer uses of void

Re: ksh: Use typedef for function pointer

2020-05-08 Thread Jeremie Courreges-Anglas
On Thu, May 07 2020, Michael Forney wrote: > I originally submitted this patch as a portability fix to Brian > Callahan's oksh, but he suggested I submit it here instead. Out of curiosity, do you run (o)ksh on machines where this matters? > Conversion of function pointer to void pointer is not a

ksh: Use typedef for function pointer

2020-05-07 Thread Michael Forney
I originally submitted this patch as a portability fix to Brian Callahan's oksh, but he suggested I submit it here instead. Conversion of function pointer to void pointer is not allowed in ISO C, though POSIX requires it for dlsym(). However, here we are also comparing function pointer to void poi