Re: iwm: always initialize index into tx queue array

2015-10-12 Thread Stefan Sperling
On Mon, Oct 12, 2015 at 11:47:08AM +0200, Martin Pieuchot wrote: > Why not using an "enum ieee80211_edca_ac" while here? Plus does it make > sense to pass a constant argument to iwm_tx()? Agreed and filed as "future work" ;-) > Anyway I'm fine with this. Thanks, committed.

Re: iwm: always initialize index into tx queue array

2015-10-12 Thread Martin Pieuchot
On 11/10/15(Sun) 14:23, Stefan Sperling wrote: > The index into sc->txq used by iwm_tx() is only initialized for > management frames. For data frames, iwm picks a garbage index off > the stack which is not initialized unless a mgmt frame was processed > first in the same loop. > > This could end r

iwm: always initialize index into tx queue array

2015-10-11 Thread Stefan Sperling
The index into sc->txq used by iwm_tx() is only initialized for management frames. For data frames, iwm picks a garbage index off the stack which is not initialized unless a mgmt frame was processed first in the same loop. This could end rather badly. Fix it the easy way for now, because overall q