Re: iwm(4) LED

2015-06-14 Thread Theo de Raadt
> Not sure the BEGIN/END mwm/led.c comments make any sense. But > otherwise this looks fine to me. They used to help. I agree, not anymore.

Re: iwm(4) LED

2015-06-14 Thread Mark Kettenis
> Date: Sun, 14 Jun 2015 21:07:49 +0200 > From: Stefan Sperling > > On Sun, Jun 14, 2015 at 07:28:44PM +0200, Mark Kettenis wrote: > > Not sure the BEGIN/END mwm/led.c comments make any sense. > > Would you agree with removing all these kinds of comments? > If so, I'll do that in a separate comm

Re: iwm(4) LED

2015-06-14 Thread Stefan Sperling
On Sun, Jun 14, 2015 at 07:28:44PM +0200, Mark Kettenis wrote: > Not sure the BEGIN/END mwm/led.c comments make any sense. Would you agree with removing all these kinds of comments? If so, I'll do that in a separate commit. They bother me as well because things change and move around a lot in Lin

Re: iwm(4) LED

2015-06-14 Thread Mark Kettenis
> Date: Sun, 14 Jun 2015 12:56:19 +0200 > From: Stefan Sperling > > On Sun, Jun 07, 2015 at 02:23:44PM +0200, Stefan Sperling wrote: > > This diff enables the wifi LED with iwm(4) devices. > > > > Tested using a non-thinkpad netbook with wifi LED. I'm not sure > > if any modern thinkpads even ha

Re: iwm(4) LED

2015-06-14 Thread Stefan Sperling
On Sun, Jun 07, 2015 at 02:23:44PM +0200, Stefan Sperling wrote: > This diff enables the wifi LED with iwm(4) devices. > > Tested using a non-thinkpad netbook with wifi LED. I'm not sure > if any modern thinkpads even have wifi LEDs these days :-/ > > Unfortunately, there seems to be know way of

iwm(4) LED

2015-06-07 Thread Stefan Sperling
This diff enables the wifi LED with iwm(4) devices. Tested using a non-thinkpad netbook with wifi LED. I'm not sure if any modern thinkpads even have wifi LEDs these days :-/ Unfortunately, there seems to be know way of controlling blinking in hardware so use a timeout instead. OK? Index: if_iw