Re: installboot: reflect script failure in exit code

2022-09-09 Thread Klemens Nanni
On Thu, Sep 08, 2022 at 03:28:29PM -0600, Todd C. Miller wrote: > On Thu, 08 Sep 2022 20:04:58 -, Klemens Nanni wrote: > > > Here's the full diff to fsck and newfs failure on all architectures. > > > > This is a regular programming issue around system(3) that has nothing to > > do with bootloa

Re: installboot: reflect script failure in exit code

2022-09-08 Thread Todd C . Miller
On Thu, 08 Sep 2022 20:04:58 -, Klemens Nanni wrote: > Here's the full diff to fsck and newfs failure on all architectures. > > This is a regular programming issue around system(3) that has nothing to > do with bootloaders or installboot per se. > > I'd be great to get this in to make further

Re: installboot: reflect script failure in exit code

2022-09-08 Thread Klemens Nanni
On Sat, Sep 03, 2022 at 12:28:33PM +, Klemens Nanni wrote: > On Fri, Aug 26, 2022 at 09:12:59AM +, Klemens Nanni wrote: > > installboot(8) runs newfs_msdos(8) via system(3) but only checks failures > > of the function itself, always returning zero no matter what newfs_msdos > > returned. >

Re: installboot: reflect script failure in exit code

2022-09-03 Thread Klemens Nanni
On Fri, Aug 26, 2022 at 09:12:59AM +, Klemens Nanni wrote: > installboot(8) runs newfs_msdos(8) via system(3) but only checks failures > of the function itself, always returning zero no matter what newfs_msdos > returned. > > This is bad for regress tests relying on correct return codes. Also

installboot: reflect script failure in exit code

2022-08-26 Thread Klemens Nanni
installboot(8) runs newfs_msdos(8) via system(3) but only checks failures of the function itself, always returning zero no matter what newfs_msdos returned. This is bad for regress tests relying on correct return codes. create_filesystem() itself must not exit as write_filesystem() calls it and c