Re: installboot: double free

2018-11-06 Thread Otto Moerbeek
On Tue, Nov 06, 2018 at 05:32:47PM +0800, Michael Mikonos wrote: > On Tue, Nov 06, 2018 at 10:20:34AM +0100, Otto Moerbeek wrote: > > On Tue, Nov 06, 2018 at 04:35:05PM +0800, Michael Mikonos wrote: > > > > > Hello, > > > > > > In installboot's fileprefix() function r is the return value > > > o

Re: installboot: double free

2018-11-06 Thread Michael Mikonos
On Tue, Nov 06, 2018 at 10:20:34AM +0100, Otto Moerbeek wrote: > On Tue, Nov 06, 2018 at 04:35:05PM +0800, Michael Mikonos wrote: > > > Hello, > > > > In installboot's fileprefix() function r is the return value > > of realpath(). If snprintf() fails free(r) happens twice--- > > the second time i

Re: installboot: double free

2018-11-06 Thread Otto Moerbeek
On Tue, Nov 06, 2018 at 04:35:05PM +0800, Michael Mikonos wrote: > Hello, > > In installboot's fileprefix() function r is the return value > of realpath(). If snprintf() fails free(r) happens twice--- > the second time is at label "err". From what I see the behavior > was introduced in util.c rev

installboot: double free

2018-11-06 Thread Michael Mikonos
Hello, In installboot's fileprefix() function r is the return value of realpath(). If snprintf() fails free(r) happens twice--- the second time is at label "err". From what I see the behavior was introduced in util.c revision 1.12. Does this fix look OK? - Michael Index: util.c