ral write of free memory if malloc option D is active. Knowing the
> place where allocations were done often helps to find out where the
> overwrite happened.
>
> If option D is active malloc now saves caller info in a separate page
> instead of only doing that for chunk index 0.
Hi,
This diff adds better error reporting for write-after-free or the more
general write of free memory if malloc option D is active. Knowing the
place where allocations were done often helps to find out where the
overwrite happened.
If option D is active malloc now saves caller info in a
tu your_program
> > > > > > > $ kdump -u mallocdumpline
> > > > > > >
> > > > > > > and for profiling:
> > > > > > >
> > > > > > > $ kdump -u profil > gmon.out
> > > >
> > > > > > filter on.
> > > > > >
> > > > > > $ MALLOC_OPTIONS=D ktrace -tu your_program
> > > > > > $ kdump -u mallocdumpline
> > > > > >
> > > > > > and for profiling:
> > > > &g
gt; > > > $ kdump -u mallocdumpline
> > > > >
> > > > > and for profiling:
> > > > >
> > > > > $ kdump -u profil > gmon.out
> > > > > $ gprof your_program gmon.out
> > > > >
> > > > &
o the call so I
> > could enrich the ktrace with userland trace info. So if kdump -u is used
> > for more then just mallocstats it should have a true binary mode. For
> > example gmon.out is a binary format so the above example by semarie@ would
> > not work. As usual this ca
> gmon.out
> > > > $ gprof your_program gmon.out
> > > >
> > > > Thanks.
> > >
> > > Thanks! Your suggestions make a lot of sense. I'll rework the kdump
> > > part to make it more flexable for different purposes.
> >
>
gt; should be line buffered). It makes the regular kdump output more useable.
> Right now you depend on kdump -u to put the lines back together.
>
> Whenever I used utrace() I normally passed binary objects to the call so I
> could enrich the ktrace with userland trace info. So if kdump -
of sense. I'll rework the kdump
> > part to make it more flexable for different purposes.
>
> Anothew aspect of safety is the information availble in the heap
> itself. I'm pretty sure the addresses of call sites into malloc are
> interesting to attackers. To prevent a prog
On Sun, Apr 09, 2023 at 09:15:12AM +0200, Otto Moerbeek wrote:
> On Sun, Apr 09, 2023 at 08:20:43AM +0200, Otto Moerbeek wrote:
>
> >
> > Thanks! Your suggestions make a lot of sense. I'll rework the kdump
> > part to make it more flexable for different purposes.
>
> Anothew aspect of safety is
endif /* MALLOC_STATS */
+#endif
while ((mopts.malloc_canary = arc4random()) == 0)
;
@@ -596,9 +600,7 @@ insert(struct dir_info *d, void *p, size
}
d->r[index].p = p;
d->r[index].size = sz;
-#ifdef MALLOC_STATS
- d->r[index].f = f;
-#endif
+
On Sun, Apr 09, 2023 at 07:53:31AM +0200, Sebastien Marie wrote:
> On Fri, Apr 07, 2023 at 09:52:52AM +0200, Otto Moerbeek wrote:
> > > Hi,
> > >
> > > This is work in progress. I have to think if the flags to kdump I'm
> > > introducing should be two or a single one.
> > >
> > > Currently, mall
On Fri, Apr 07, 2023 at 09:52:52AM +0200, Otto Moerbeek wrote:
> > Hi,
> >
> > This is work in progress. I have to think if the flags to kdump I'm
> > introducing should be two or a single one.
> >
> > Currently, malloc.c can be compiled with MALLOC_STATS defined. If run
> > with option D it dump
;
> Feedback appreciated.
Second iteration. Main difference: docs and the leak report is greatly
enhanced by adding info that can be fed to addr2line. Exmaple:
...
Leak report:
f sum #avg
0x9fd0eb58abb 40960 10 4096 addr2line -e ./a.out 0x1abb
Hi,
This is work in progress. I have to think if the flags to kdump I'm
introducing should be two or a single one.
Currently, malloc.c can be compiled with MALLOC_STATS defined. If run
with option D it dumps its state to a malloc.out file at exit. This
state can be used to find leaks amongst othe
On Wed, Nov 02, 2022 at 11:55:12AM +0100, Claudio Jeker wrote:
> Job's diff made me realise that clearing the connection info (conn->res)
> makes error reporting worse. It is not like we save lots of memory by
> doing so. So do not call freeaddrinfo() in http_connect_done(), now
&
Job's diff made me realise that clearing the connection info (conn->res)
makes error reporting worse. It is not like we save lots of memory by
doing so. So do not call freeaddrinfo() in http_connect_done(), now
http_free() will free res0 before freeing conn.
--
:wq Claudio
Index
On Tue, Sep 20, 2022 at 02:34:08PM +0100, Jason McIntyre wrote:
> On Tue, Sep 20, 2022 at 08:37:27AM -0300, Crystal Kolipe wrote:
> > On Tue, Sep 20, 2022 at 10:54:10AM +, Klemens Nanni wrote:
> > > Reads like pointing out the obvious and the next sentence also explains
> > > how -H and -L beha
Thanks Crystal and Jason,
the existing wording makes more sense to me and I'd leave it as is.
On Tue, Sep 20, 2022 at 08:37:27AM -0300, Crystal Kolipe wrote:
> On Tue, Sep 20, 2022 at 10:54:10AM +, Klemens Nanni wrote:
> > Does this negation of the main sentence add anything I don't get?
>
> Yes. The wording you are proposing to remove makes it clear that
> setting -R sets the 'defaul
On Tue, Sep 20, 2022 at 10:54:10AM +, Klemens Nanni wrote:
> Does this negation of the main sentence add anything I don't get?
Yes. The wording you are proposing to remove makes it clear that
setting -R sets the 'default' behaviour, (which can be overridden
by other flags), rather than forcin
Does this negation of the main sentence add anything I don't get?
Reads like pointing out the obvious and the next sentence also explains
how -H and -L behave due to -R, just like -H and -L descriptions
themselves.
Index: cp.1
===
RC
On Thu, Aug 25, 2022 at 05:06:33PM +, Job Snijders wrote:
> On Thu, Aug 25, 2022 at 06:38:36PM +0200, Theo Buehler wrote:
> > On Thu, Aug 25, 2022 at 04:04:27PM +, Job Snijders wrote:
> > > On Thu, Aug 25, 2022 at 03:38:45PM +0200, Claudio Jeker wrote:
> > > > I wonder why is PEM printing n
On Thu, Aug 25, 2022 at 06:38:36PM +0200, Theo Buehler wrote:
> On Thu, Aug 25, 2022 at 04:04:27PM +, Job Snijders wrote:
> > On Thu, Aug 25, 2022 at 03:38:45PM +0200, Claudio Jeker wrote:
> > > I wonder why is PEM printing not part of -f? It seems to be something
> > > that should be part of f
On Thu, Aug 25, 2022 at 04:04:27PM +, Job Snijders wrote:
> On Thu, Aug 25, 2022 at 03:38:45PM +0200, Claudio Jeker wrote:
> > I wonder why is PEM printing not part of -f? It seems to be something
> > that should be part of filemode.
>
> OK, how about this?
That's a lot better. However X509_p
On Thu, Aug 25, 2022 at 03:38:45PM +0200, Claudio Jeker wrote:
> I wonder why is PEM printing not part of -f? It seems to be something
> that should be part of filemode.
OK, how about this?
Kind regards,
Job
Index: filemode.c
===
R
On Tue, Jan 11, 2022 at 11:36:19AM +, Job Snijders wrote:
> On Mon, Jan 10, 2022 at 03:30:23PM +0100, Claudio Jeker wrote:
> > + if (RB_INSERT(repo_tree, &repos, rp) != NULL)
> > + errx(1, "repository already added to repo tree %d, %s", id,
> > path);
> > + warnx("repository adde
On Mon, Jan 10, 2022 at 03:30:23PM +0100, Claudio Jeker wrote:
> + if (RB_INSERT(repo_tree, &repos, rp) != NULL)
> + errx(1, "repository already added to repo tree %d, %s", id,
> path);
> + warnx("repository added to repo tree %d, %s", id, path);
The above warnx() probably nee
On Mon, Jan 10, 2022 at 03:30:23PM +0100, Claudio Jeker wrote:
> This diff changes the way the parser figures out which file to work on.
> Until now the parent process sent a full path to the parser but that does
> not work well with the idea of splitting the repo up into validated, rsync
> and rrd
@@ -86,7 +86,7 @@ struct tarepo {
unsigned int id;
enum repo_state state;
};
-SLIST_HEAD(, tarepo) tarepos = SLIST_HEAD_INITIALIZER(tarepos);
+static SLIST_HEAD(, tarepo)tarepos = SLIST_HEAD_INITIALIZER(tarepos);
struct repo {
SLIST_EN
Hi,
I noticed bgpctl didn't seem to have a way to show the MPLS label
attached to MPLS L3VPN routes. The label was already there in the prefix
info it just wasn't printed, so this diff adds printing the label info
if the prefix has one in the show rib detail command.
Example output be
On Tue, Jun 15, 2021 at 06:14:38PM +0200, Claudio Jeker wrote:
> The Adj-RIB-Out should show what is sent to the peer. bgpd did not fully
> do that since it adjusted the ASPATH and the nexthop afterwards when
> building the actual UPDATE.
>
> This diff changes that and moves the ASPATH prepend for
The Adj-RIB-Out should show what is sent to the peer. bgpd did not fully
do that since it adjusted the ASPATH and the nexthop afterwards when
building the actual UPDATE.
This diff changes that and moves the ASPATH prepend for ebgp sessions and
the selection of the nexthop. Thanks to this the outpu
; > On Sun, Nov 29, 2020 at 11:25 PM Jonathan Gray wrote:
> >
> > > On Sun, Nov 29, 2020 at 10:17:22PM -0600, Charlie Burnett wrote:
> > > > Howdy all,
> > > > For reasons that are beyond me, when printf is called in
> amdgpu_device.c
> > >
ote:
> > > Howdy all,
> > > For reasons that are beyond me, when printf is called in amdgpu_device.c
> > to
> > > print the CU info, it gives me a psp firmware load failure on a Radeon
> > VII
> > > (Vega 20) gpu. Switching the printf statement to a DRM_
Howdy all,
> > For reasons that are beyond me, when printf is called in amdgpu_device.c
> to
> > print the CU info, it gives me a psp firmware load failure on a Radeon
> VII
> > (Vega 20) gpu. Switching the printf statement to a DRM_INFO statement as
> > used in the rest of
On Sun, Nov 29, 2020 at 10:17:22PM -0600, Charlie Burnett wrote:
> Howdy all,
> For reasons that are beyond me, when printf is called in amdgpu_device.c to
> print the CU info, it gives me a psp firmware load failure on a Radeon VII
> (Vega 20) gpu. Switching the printf statement t
Howdy all,
For reasons that are beyond me, when printf is called in amdgpu_device.c to
print the CU info, it gives me a psp firmware load failure on a Radeon VII
(Vega 20) gpu. Switching the printf statement to a DRM_INFO statement as
used in the rest of amdgpu seems to fix it though.
ok?
diff
Hello,
On Mon, Jul 20, 2020 at 03:23:41PM +0200, Klemens Nanni wrote:
> Getting the checksum with pfctl(8) is either in your finger's muscle
> memory or takes guess work as the manual doesn't mention it.
>
> I grepped the code to see that I need `-s info' with `-v
Getting the checksum with pfctl(8) is either in your finger's muscle
memory or takes guess work as the manual doesn't mention it.
I grepped the code to see that I need `-s info' with `-v'.
(Setting) hostid is described in pf.conf(5) but pfctl(8) doesn't tell us
how to pr
I was looking for something in a devices VPD info and got this far
before finding out it wasn't there. I'm a bit over it now though.
PCI VPD stuff is weird because the capability doesn't contain the data
itself, it's a register that lets you communicate with whatever is
sto
On Tue, May 19, 2020 at 11:36:23PM +0200, Patrick Wildt wrote:
> Hi,
>
> drahn@ was complaining to me that his cross-compiler wasn't defining
> __OpenBSD__ or __ELF__, and I think the fix is pretty simple. We're
> just missing a case in a switch-case.
>
> The .cpp file itself still compiles, but
> Date: Tue, 19 May 2020 23:36:23 +0200
> From: Patrick Wildt
>
> Hi,
>
> drahn@ was complaining to me that his cross-compiler wasn't defining
> __OpenBSD__ or __ELF__, and I think the fix is pretty simple. We're
> just missing a case in a switch-case.
>
> The .cpp file itself still compiles,
Hi,
drahn@ was complaining to me that his cross-compiler wasn't defining
__OpenBSD__ or __ELF__, and I think the fix is pretty simple. We're
just missing a case in a switch-case.
The .cpp file itself still compiles, but I haven't built a full clang
with it. Please give it a go and report back.
this adds a couple of lines to the lacp output so you can see what
params are used on the wire. this can help if you've put switchports in
different port-channels or such. an example of that is:
aggr0: flags=8847 mtu 1500
lladdr fe:e1:ba:d0:35:21
index 10 priority 0 llprio 7
On Thu, Apr 11, 2019 at 08:28:37AM +1000, David Gwynne wrote:
> seeing the key-id in particular helped me debug a problem here.
>
> ok?
OK bluhm@
> Index: ospf.h
> ===
> RCS file: /cvs/src/usr.sbin/tcpdump/ospf.h,v
> retrieving revis
seeing the key-id in particular helped me debug a problem here.
ok?
Index: ospf.h
===
RCS file: /cvs/src/usr.sbin/tcpdump/ospf.h,v
retrieving revision 1.10
diff -u -p -r1.10 ospf.h
--- ospf.h 4 Aug 2010 16:47:01 - 1.10
On 8.4.2019. 22:13, Stuart Henderson wrote:
> On 2019/04/08 19:55, Hrvoje Popovski wrote:
>> On 8.4.2019. 11:33, David Gwynne wrote:
>>> this updates the ifconfig part of the diff
>> This is great feature... thank you ..
>> it would be great if dBm could be exported via snmp :)
> You can do this vi
On 8.4.2019. 19:55, Hrvoje Popovski wrote:
> On 8.4.2019. 11:33, David Gwynne wrote:
>> this updates the ifconfig part of the diff
>
> This is great feature... thank you ..
maybe to put laser wavelength in sff output?
ix0 - 1000BASE-LX
x3550m4# ifconfig ix0 sff
ix0: identifier SFP (03)
c
FWIW (I was interested so put something together), here's a sample diff
on top with one method of printing alarms. (I went for the < > checks
rather than table 3.18 flag bits, mostly because I didn't fancy the
"check again after 100ms" that the latter wanted).
--- sff.c.orig Mon Apr 8 22:27:45 2
On 2019/04/08 19:55, Hrvoje Popovski wrote:
> On 8.4.2019. 11:33, David Gwynne wrote:
> > this updates the ifconfig part of the diff
>
> This is great feature... thank you ..
> it would be great if dBm could be exported via snmp :)
You can do this via net-snmp already:
http://sysadvent.blogspot.c
Flag = False
> SFP+ 6 Voltage Low Warning Flag = False
> SFP+ 6 Tx Bias Low Warning Flag = False
> SFP+ 6 Tx Power Low Warning Flag= False
> SFP+ 6 Rx Power Low Warning Flag= False
>
> 10GBASE-SR
>
>
> On Mon, Apr 08, 2019 at 02:21:36
On 8.4.2019. 11:33, David Gwynne wrote:
> this updates the ifconfig part of the diff
This is great feature... thank you ..
it would be great if dBm could be exported via snmp :)
switch - Dell S4810
ix0 - sfp+ 10GBASE-SR optics
ix1 - sfp 1000BASE-SX optics
ixl0 - 10G passive DAC cables
x3550m4#
On 2019/04/08 13:57, Stuart Henderson wrote:
> Here's a complete diff. Tested on amd64 with ix, working great there.
> distrib/special/ifconfig still builds okay, I'll run a full mkr later on
> i386/amd64.
>
> This is extremely useful for the bgpd "target market" ;)
oops, here's attempt #2 with t
Here's a complete diff. Tested on amd64 with ix, working great there.
distrib/special/ifconfig still builds okay, I'll run a full mkr later on
i386/amd64.
This is extremely useful for the bgpd "target market" ;)
Index: sbin/ifconfig/Makefile
===
wrote:
> this adds support to ifconfig for reading info from transceivers.
>
> it looks like this:
>
> dlg@ix ifconfig$ sudo ./obj/ifconfig ix0 transceiver
> ix0: identifier SFP (03)
> connector: Copper Pigtail (21)
> vendor: Amphenol
> product: 61
this adds support to ifconfig for reading info from transceivers.
it looks like this:
dlg@ix ifconfig$ sudo ./obj/ifconfig ix0 transceiver
ix0: identifier SFP (03)
connector: Copper Pigtail (21)
vendor: Amphenol
product: 616740001
revision: B
serial
On Thu, Dec 20, 2018 at 07:39:44PM -0500, Chris McGee wrote:
> That looks much better to me, though it does get machine-specific
>
> I feel like it would be more clear if the examples uniformly used your
> new variable
> convention, as some do and some do not. This allows us to eliminate one
> ex
Den fre 21 dec. 2018 kl 01:40 skrev Chris McGee :
>
> I feel like it would be more clear if the examples uniformly used your
> new variable
> convention, as some do and some do not. This allows us to eliminate one
> example
> too. (I assume the ER Lite does OK if you specify numcores=1 ? )
"does
octlinux rootdev=sd0
numcores=
+ usb reset; fatload usb 0 ${loadaddr} bsd; bootoctlinux rootdev=sd0 numcores=2
OpenBSDCongratulations
On Tue, Dec 18, 2018 at 11:40 AM Visa Hankala wrote:
>
> On Mon, Dec 17, 2018 at 11:22:40PM -0500, Chris McGee wrote:
> > Hi:
> >
> >
On Mon, Dec 17, 2018 at 11:22:40PM -0500, Chris McGee wrote:
> Hi:
>
> I would like to add some info for Edgerouter 6
> (and presumably ER4, and maybe also ER12?) to install64.octeon.
> The document is great but it won't get a new user booting on the new
> 4-core m
On Mon, Dec 17, 2018 at 11:22:40PM -0500, Chris McGee wrote:
> so for example it mentions that you're going to need to drop
> bsd.mp into the msdos kernel loader partition but doesn't explain how
> to do that. Seemed to be the right level of detail for this document.
The installer is supposed to p
Hi:
I would like to add some info for Edgerouter 6
(and presumably ER4, and maybe also ER12?) to install64.octeon.
The document is great but it won't get a new user booting on the new
4-core machines with MMC drives.
I tried to make it as brief as possible while pointing the user in the
On Sat, 26 May 2018 22:44:56 +0930
Jack Burton wrote:
> This diff adds three new TLS_PEER_* fastcgi variables: ISSUER, SERIAL
> & SUBJECT.
>
> That seems the logical next step in making tls client certs usable for
> authorisation & accounting. Last week's commit (thanks Joel!) took
> care of auth
Hi,
sending this to a wider audience on misc@, to fix the microphone (cf
https://marc.info/?t=15298427072&r=1&w=2) on a
variety of logitech webcams (mostly the Cxxx{,HD}?) i'd need the lsusb
-v output for the corresponding devices.
If you have a logitech webcam where the mic doesnt work (look
This diff adds three new TLS_PEER_* fastcgi variables: ISSUER, SERIAL &
SUBJECT.
That seems the logical next step in making tls client certs usable for
authorisation & accounting. Last week's commit (thanks Joel!) took care
of authentication.
The cert subject on its own should suffice for the sim
Hi,
prompted by mpi@ i tried simplifying the way we get the
vendor/product/serial info from the device. Currently this is done
lazily, and sometimes several times. Instead of this, let's query the
device in usbd_new_device(), fallback to the global known lists then to
the USB IDs, cache the
Similar to what we do on other architectures with .eh_frame. Reduces
the growth when compiling kernels with clang.
Index: arch/arm/conf/ldscript.tail
===
RCS file: /cvs/src/sys/arch/arm/conf/ldscript.tail,v
retrieving revision 1.4
di
On 12/10/2017 17:04, Tom Smyth wrote:
Hi Ingo,
First of all thanks for the feedback it is appreciated,
especially when you think the thread is a waste of time.
so rather than look for feedback on another patch for now
If you could bear with me and let me outline
why I think this thread is impo
Hi Ingo,
First of all thanks for the feedback it is appreciated,
especially when you think the thread is a waste of time.
so rather than look for feedback on another patch for now
If you could bear with me and let me outline
why I think this thread is important
important enough to be my first pr
Hi Tom,
it is still completely unclear what you are even trying to talk
about. The patch is certainly not acceptable, it is vague,
highly confusing, and fails to state what it is all about.
If what you are trying to document is the so-called "IP unnumbered"
hack: That is an abomination brewed b
Hello Stuart, all,
Thanks for the corrections Stuart,
I have corrected the patch to take into account your suggestions
and I hope this proposed patch is more correct and useful
Index: src/share/man/man5/hostname.if.5
===
RCS file: /cvs
Updated diff below now that the first bits got committed.
gopi can be used safely instead of an extra info struct, so munge it.
Declaring the gop and gopi strucutures globally makes things easier in
preparation for the next commit.
Both changes also improve consistency with regard to other
On 2017/10/02 03:04, Tom Smyth wrote:
> Hello,
>
> But the Ip configuration syntax in hostname.if is the same.
For a /31 you just use e.g. "inet 192.0.2.100/31" (and it works properly
in other parts of the system, e.g. ospfd).
> Is there anything specifically wrong in the proposed patch ?
This
Hello,
But the Ip configuration syntax in hostname.if is the same.
(appart from a /31 having a sequential ip address pair that starts
on an even numbered ip) while a point to point / ip unumbered setup
would have any arbitary pair of ips on the interface.
Is there anything specifically wrong in th
On 2017/10/01 19:18, Tom Smyth wrote:
> so the point to point addressing scheme is for saving ips sometimes
> it can be referred to incorrectly in my opinion as /31 addressing
It's totally different to /31.
> (well it is more like 2x /32 addresses) but it can be a
What you're suggesting is mor
the hostname.if file
and hey presto your link works
comments suggestions and criticisms welcome
Thanks
On 24 September 2017 at 13:12, Tom Smyth wrote:
> Hello lads, and ladies,
> I have included some extra info on point to point addressing on
> interfaces in OpenBSD thanks @tedu for
Hello lads, and ladies,
I have included some extra info on point to point addressing on
interfaces in OpenBSD thanks @tedu for the blog post that helpd me
learn how to do point to point addressing (non Broadcast) on Openbsd
and @theo @ingo for pointing me in the right direction on man page
gopi is only used for filling ei after info's last usage. info is more
descriptive imho and reusing it gets rid of the extra variable.
Feedback?
diff --git a/sys/arch/amd64/stand/efiboot/efiboot.c
b/sys/arch/amd64/stand/efiboot/efiboot.c
index 42e79fbea6b..1ed2968bffa 100644
--- a/sys
> Date: Thu, 13 Jul 2017 14:54:41 +0200
> From: Alexander Bluhm
>
> Hi,
>
> The regress test src/regress/sys/kern/siginfo-fault checks wether
> the si_code is set to SEGV_ACCERR after memory access with wrong
> permissions has triggert a SIGSEGV.
>
> Relevant commit message of the test is:
>
Hi,
The regress test src/regress/sys/kern/siginfo-fault checks wether
the si_code is set to SEGV_ACCERR after memory access with wrong
permissions has triggert a SIGSEGV.
Relevant commit message of the test is:
According to POSIX, SIGSEGV should specify SEGV_ACCERR if the memory
pages are
On Tue, May 30, 2017 at 11:06:10AM +0200, Michal Mazurek wrote:
> On 10:43:30, 30.05.17, Job Snijders wrote:
> > In the registry created by RFC 6608, the value "0" is the BGP Finite
> > State Machine Error subcode meaning "Unspecified Error". I think that
> > when a name is assigned to a value, the
On 10:43:30, 30.05.17, Job Snijders wrote:
> In the registry created by RFC 6608, the value "0" is the BGP Finite
> State Machine Error subcode meaning "Unspecified Error". I think that
> when a name is assigned to a value, the name should be printed (like
> your patch does for subcode values 1, 2,
On Tue, May 30, 2017 at 10:21:17AM +0200, Michal Mazurek wrote:
> On 12:15:06, 29.05.17, Job Snijders wrote:
> > perhaps add a comment like /* RFC 6608 */ above the below:
>
> Right, it will make it more consistent.
>
> > > +static const char *bgpnotify_minor_fsm[] = {
> > > + NULL, "In OpenSent
On Tue, May 30, 2017 at 10:21:17AM +0200, Michal Mazurek wrote:
> On 12:15:06, 29.05.17, Job Snijders wrote:
> > perhaps add a comment like /* RFC 6608 */ above the below:
>
> Right, it will make it more consistent.
>
> > > +static const char *bgpnotify_minor_fsm[] = {
> > > + NULL, "In OpenSent
On 2017 May 30 (Tue) at 10:21:17 +0200 (+0200), Michal Mazurek wrote:
:On 12:15:06, 29.05.17, Job Snijders wrote:
:> perhaps add a comment like /* RFC 6608 */ above the below:
:
:Right, it will make it more consistent.
:
:> > +static const char *bgpnotify_minor_fsm[] = {
:> > + NULL, "In OpenSent
> > > +static const char *bgpnotify_minor_fsm[] = {
> > > + NULL, "In OpenSent State", "In OpenConfirm State",
> > > + "In Established State",
> > > +};
> >
> > and maybe s/NULL/"Unspecified Error"/
>
> If it's NULL, then tcpdump will print out the number:
>
> if (p == NULL) {
>
On 12:15:06, 29.05.17, Job Snijders wrote:
> perhaps add a comment like /* RFC 6608 */ above the below:
Right, it will make it more consistent.
> > +static const char *bgpnotify_minor_fsm[] = {
> > + NULL, "In OpenSent State", "In OpenConfirm State",
> > + "In Established State",
> > +};
>
>
On Mon, May 29, 2017 at 12:02:33PM +0200, Michal Mazurek wrote:
> The error information for bgp was commited in 2009
> (bgpnotify_minor_cease, bgpnotify_minor_cap) but never enabled, so do
> that here. Also add FSM error codes.
perhaps add a comment like /* RFC 6608 */ above the below:
> +static
The error information for bgp was commited in 2009 (bgpnotify_minor_cease,
bgpnotify_minor_cap) but never enabled, so do that here. Also add FSM error
codes.
Index: print-bgp.c
===
RCS file: /cvs/src/usr.sbin/tcpdump/print-bgp.c,v
ret
Hello,
On Sun, Apr 23, 2017 at 12:18:07AM +0200, Hiltjo Posthuma wrote:
> On Sat, Apr 22, 2017 at 08:14:06AM +0900, YASUOKA Masahiko wrote:
> > On Fri, 21 Apr 2017 13:52:51 +0900 (JST)
> > YASUOKA Masahiko wrote:
> > > +int
> > > +pfctl_parse_host(char *str, struct pf_rule_addr *addr)
> > > +{
>
On Sun, 23 Apr 2017 00:18:07 +0200
Hiltjo Posthuma wrote:
> On Sat, Apr 22, 2017 at 08:14:06AM +0900, YASUOKA Masahiko wrote:
>> On Fri, 21 Apr 2017 13:52:51 +0900 (JST)
>> YASUOKA Masahiko wrote:
>> > +int
>> > +pfctl_parse_host(char *str, struct pf_rule_addr *addr)
>> > +{
>> (snip)
>> > + if
On Sat, Apr 22, 2017 at 08:14:06AM +0900, YASUOKA Masahiko wrote:
> On Fri, 21 Apr 2017 13:52:51 +0900 (JST)
> YASUOKA Masahiko wrote:
> > +int
> > +pfctl_parse_host(char *str, struct pf_rule_addr *addr)
> > +{
> (snip)
> > + if ((sbs = strchr(s, '[')) != NULL || (sbe = strrchr(s, ']')) != NULL)
On Sat, Apr 22, 2017 at 08:14:06AM +0900, YASUOKA Masahiko wrote:
> On Fri, 21 Apr 2017 13:52:51 +0900 (JST)
> YASUOKA Masahiko wrote:
> > +int
> > +pfctl_parse_host(char *str, struct pf_rule_addr *addr)
> > +{
> (snip)
> > + if ((sbs = strchr(s, '[')) != NULL || (sbe = strrchr(s, ']')) != NULL)
On Fri, 21 Apr 2017 13:52:51 +0900 (JST)
YASUOKA Masahiko wrote:
> +int
> +pfctl_parse_host(char *str, struct pf_rule_addr *addr)
> +{
(snip)
> + if ((sbs = strchr(s, '[')) != NULL || (sbe = strrchr(s, ']')) != NULL) {
> + hints.ai_family = AF_INET6;
> + *(sbs++) = *sbe
Hi,
On Fri, 21 Apr 2017 00:27:04 +0200
Alexandr Nedvedicky wrote:
> I finally got to your patch. I'm fine with your to extend pfctl kill
> operation.
>
> I've found just few nits in your change.
>
> 1) your manpage diff should include one more change below:
> 8<---8<---
Hello,
I finally got to your patch. I'm fine with your to extend pfctl kill operation.
I've found just few nits in your change.
1) your manpage diff should include one more change below:
8<---8<---8<--8<
diff -r c435e977886a -r 40aa0af6
Hi,
I'd like to add "key" modifier to "pfctl -k" to delete pf states, like
below:
# pfctl -k key -k 'tcp 10.0.0.1:80 <- 10.0.0.101:32123'
This deletion will be very fast if the RB tree of pf state table is
used to find the state. The diff also includes the diff for that part
(DIOCKILLSTATES o
This diff adds dhcrelay support for replacing Relay Agent Information
on incoming packets with our configuration. This might be useful if you
want to override user sent information or to adapt the incoming packet to
another network.
ok?
Index: dhcrelay.8
==
-
> @@ -60,6 +60,7 @@ install:maninstall
> sh ${.CURDIR}/util/gen-dir-node ${DESTDIR}/usr/share/info > \
> ${DESTDIR}/usr/share/info/dir
> chown ${MANOWN}:${MANGRP} ${DESTDIR}/usr/share/info/dir
> + chmod ${MANMODE} ${DESTDIR}/usr/share/info/dir
>
> clean cleandir:
> rm -f ${CLEANFILES}
>
1 - 100 of 154 matches
Mail list logo
