Re: ifstated pidfile

2010-06-07 Thread Marco Pfatschbacher
On Mon, Jun 07, 2010 at 09:33:34AM +0200, Michael Lechtermann wrote: > Hi, > > >> Well, that makes sense. But what about not showing the arguments > >> ifstated was started with? Any reason to wipe them? It would really help > >> to identify the correct process when those are showed. > >> > >> Wha

Re: ifstated pidfile

2010-06-07 Thread Michael Lechtermann
Hi, >> Well, that makes sense. But what about not showing the arguments >> ifstated was started with? Any reason to wipe them? It would really help >> to identify the correct process when those are showed. >> >> What I mean is: >> setproctitle(NULL); > > I have asked a two developers why that was

Re: ifstated pidfile

2010-06-05 Thread Theo de Raadt
> Am 05.06.2010 18:51, schrieb Theo de Raadt: > >> since it is possible to supply a config file to ifstated and run it > >> multiple times with different configs, I thought it nice for it to also > >> write a pidfile _and_ actually show in ps which arguments it got. > > > > When possible, we don't

Re: ifstated pidfile

2010-06-05 Thread Michael Lechtermann
Am 05.06.2010 18:51, schrieb Theo de Raadt: >> since it is possible to supply a config file to ifstated and run it >> multiple times with different configs, I thought it nice for it to also >> write a pidfile _and_ actually show in ps which arguments it got. > > When possible, we don't use pidfile

Re: ifstated pidfile

2010-06-05 Thread Theo de Raadt
> since it is possible to supply a config file to ifstated and run it > multiple times with different configs, I thought it nice for it to also > write a pidfile _and_ actually show in ps which arguments it got. When possible, we don't use pidfiles. You can't do anything with a pidfile. It is a

ifstated pidfile

2010-06-05 Thread Michael Lechtermann
Hi, since it is possible to supply a config file to ifstated and run it multiple times with different configs, I thought it nice for it to also write a pidfile _and_ actually show in ps which arguments it got. Below is a diff that does just that. The pidfile part is stolen from isakmpd. ;-) Mic