Re: ifiq_destroy() vs NET_LOCK()

2018-01-23 Thread Alexander Bluhm
On Tue, Jan 23, 2018 at 03:43:35PM +0100, Martin Pieuchot wrote: > ifiq_destroy() is not called with the NET_LOCK() held, so there's no > need to check for that. > > Simply put an assert. OK bluhm@ > Index: net/ifq.c > === > RCS fil

Re: ifiq_destroy() vs NET_LOCK()

2018-01-23 Thread David Gwynne
> On 24 Jan 2018, at 00:43, Martin Pieuchot wrote: > > ifiq_destroy() is not called with the NET_LOCK() held, so there's no > need to check for that. > > Simply put an assert. ok. > > Index: net/ifq.c > === > RCS file: /cvs/src/

ifiq_destroy() vs NET_LOCK()

2018-01-23 Thread Martin Pieuchot
ifiq_destroy() is not called with the NET_LOCK() held, so there's no need to check for that. Simply put an assert. Index: net/ifq.c === RCS file: /cvs/src/sys/net/ifq.c,v retrieving revision 1.21 diff -u -p -r1.21 ifq.c --- net/ifq.c