Re: ifconfig compiler warnings

2019-10-23 Thread Theo de Raadt
Looks great to me. Alexander Bluhm wrote: > On Thu, Oct 17, 2019 at 04:23:32PM +0200, Alexander Bluhm wrote: > > There are more warnings, but the diff is long enough already. > > Here is the next part to fix ifconfig warnings. The global variable > "name" is the interface name. Sometimes it i

Re: ifconfig compiler warnings

2019-10-23 Thread Alexander Bluhm
On Thu, Oct 17, 2019 at 04:23:32PM +0200, Alexander Bluhm wrote: > There are more warnings, but the diff is long enough already. Here is the next part to fix ifconfig warnings. The global variable "name" is the interface name. Sometimes it is passed as parameter, sometimes it is accessed directl

Re: ifconfig compiler warnings

2019-10-18 Thread Sebastian Benoit
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.10.17 16:23:32 +0200: > Hi, > > I would like to fix some warings in ifconfig when compiled with > WARNINGS=yes. > > - Move all prototypes and variables used in multiple .c files into > common ifconfig.h. Basically rename brconfig.h to ifconfig.h

ifconfig compiler warnings

2019-10-17 Thread Alexander Bluhm
Hi, I would like to fix some warings in ifconfig when compiled with WARNINGS=yes. - Move all prototypes and variables used in multiple .c files into common ifconfig.h. Basically rename brconfig.h to ifconfig.h and also use it for sff.c. - Fix missing prototypes. - Global variable s is a bad