Re: httpd patterns double free

2016-02-14 Thread Sebastien Marie
On Thu, Feb 11, 2016 at 03:50:24PM +0100, Alexander Schrijver wrote: > > The patch below fixed it for me. (server_close_http calls str_match_free and > server_close_http can be called more than once.) > > Index: patterns.c > === > RC

Re: httpd patterns double free

2016-02-14 Thread Sebastien Marie
On Sun, Feb 14, 2016 at 03:54:04PM +0100, Alexander Schrijver wrote: > On Sun, Feb 14, 2016 at 12:20:53PM +0100, Martin Natano wrote: > > Are you sure the issue you ran into is caused by server_close_http() > > being called twice? The only caller thereof is server_free(), which also > > frees the c

Re: httpd patterns double free

2016-02-14 Thread Alexander Schrijver
On Sun, Feb 14, 2016 at 12:20:53PM +0100, Martin Natano wrote: > Are you sure the issue you ran into is caused by server_close_http() > being called twice? The only caller thereof is server_free(), which also > frees the client struct. This would result in use after free in > server_close_http() ev

Re: httpd patterns double free

2016-02-14 Thread Martin Natano
On Thu, Feb 11, 2016 at 03:50:24PM +0100, Alexander Schrijver wrote: > I ran into this issue when setting up my public_html folder using this > configuration. > > prefork 2 > > server "default" { >listen on * port 80 > >location match "/~*" { > root "/users" >} > } > > types

httpd patterns double free

2016-02-11 Thread Alexander Schrijver
I ran into this issue when setting up my public_html folder using this configuration. prefork 2 server "default" { listen on * port 80 location match "/~*" { root "/users" } } types { text/csscss text/html html htm text/txtt