Re: httpd: fix/consistency cast for ctype function

2018-11-03 Thread Philip Guenther
On Fri, Nov 2, 2018 at 4:14 AM Hiltjo Posthuma wrote: > I noticed many ctype functions (such as isalpha, isdigit, tolower) are > cast to > unsigned char in httpd. This patch changes it also for one remaining check. > Yep. Committed. Thanks! Philip Guenther

httpd: fix/consistency cast for ctype function

2018-11-02 Thread Hiltjo Posthuma
Hi, I noticed many ctype functions (such as isalpha, isdigit, tolower) are cast to unsigned char in httpd. This patch changes it also for one remaining check. I'm not sure the cast is neccessary on OpenBSD, but it is undefined behaviour I think as described in the man page isalpha(3): "CAVEATS