Re: hexdump in boot loader

2019-11-27 Thread Theo de Raadt
Alexander Bluhm wrote: > On Tue, Nov 26, 2019 at 04:51:36PM -0700, Theo de Raadt wrote: > > ok with me > > So here is the full diff with all architecture makefiles that may > be affected. > > I have done a build release on amd64. Boot loader on i386, armv7, > arm64, macppc compiles and links.

Re: hexdump in boot loader

2019-11-27 Thread Alexander Bluhm
On Tue, Nov 26, 2019 at 04:51:36PM -0700, Theo de Raadt wrote: > ok with me So here is the full diff with all architecture makefiles that may be affected. I have done a build release on amd64. Boot loader on i386, armv7, arm64, macppc compiles and links. hppa, landisk, octeon is just a guess wh

Re: hexdump in boot loader

2019-11-26 Thread Theo de Raadt
>This strtoll() version has less error checking, does not work with >addresses >=3D 0x8000, but reduces stripped boot size by >64 bytes. easier to read. that type of compromise is very common in the bootblocks. ok with me

Re: hexdump in boot loader

2019-11-26 Thread Alexander Bluhm
On Tue, Nov 26, 2019 at 04:05:34PM -0700, Theo de Raadt wrote: > >On Tue, Nov 26, 2019 at 05:27:03PM -0500, Ted Unangst wrote: > >> why not use strtol here? > > > >Basically I was not aware that it is available in the boot loader. > >And I need an unsigned long. Should I change the diff anyway? >

Re: hexdump in boot loader

2019-11-26 Thread Mark Kettenis
> Date: Tue, 26 Nov 2019 23:22:14 +0100 > From: Alexander Bluhm > > Hi, > > I am currently debugging an UEFI boot problem. A hexdump in the > boot loader would be convenient. > > boot> hexdump 0x10 20 > 0010 53 ff 00 f0 54 ff 00 f0 53 ff 00 f0 53 ff 00 f0 |S...T...S...S...| > 0020

Re: hexdump in boot loader

2019-11-26 Thread Theo de Raadt
>On Tue, Nov 26, 2019 at 05:27:03PM -0500, Ted Unangst wrote: >> why not use strtol here? > >Basically I was not aware that it is available in the boot loader. >And I need an unsigned long. Should I change the diff anyway? bootblocks can be tight on some media, so use the smallest code.

Re: hexdump in boot loader

2019-11-26 Thread Alexander Bluhm
On Tue, Nov 26, 2019 at 05:27:03PM -0500, Ted Unangst wrote: > why not use strtol here? Basically I was not aware that it is available in the boot loader. And I need an unsigned long. Should I change the diff anyway? bluhm

Re: hexdump in boot loader

2019-11-26 Thread Ted Unangst
Alexander Bluhm wrote: > + > + for (n = 1; n < cmd.argc; n++) { > + p = cmd.argv[n]; > + if (*p == '0') { > + p++; > + if (*p == 'x' || *p == 'X') { > + p++; > + b = 16; > +

hexdump in boot loader

2019-11-26 Thread Alexander Bluhm
Hi, I am currently debugging an UEFI boot problem. A hexdump in the boot loader would be convenient. boot> hexdump 0x10 20 0010 53 ff 00 f0 54 ff 00 f0 53 ff 00 f0 53 ff 00 f0 |S...T...S...S...| 0020 a5 fe 00 f0 || 0024 Do we want such a