Re: grep: add --null flag

2021-01-26 Thread Jordan Geoghegan
On 1/26/21 12:13 PM, Stuart Henderson wrote: > On 2021/01/26 11:18, Jordan Geoghegan wrote: >> >> On 1/26/21 5:47 AM, Stuart Henderson wrote: >>> On 2021/01/25 00:53, Sebastian Benoit wrote: Sebastian Benoit(be...@openbsd.org) on 2021.01.25 00:27:05 +0100: > Theo de Raadt(dera...@openbs

Re: grep: add --null flag

2021-01-26 Thread Stuart Henderson
On 2021/01/26 11:18, Jordan Geoghegan wrote: > > > On 1/26/21 5:47 AM, Stuart Henderson wrote: > > On 2021/01/25 00:53, Sebastian Benoit wrote: > >> Sebastian Benoit(be...@openbsd.org) on 2021.01.25 00:27:05 +0100: > >>> Theo de Raadt(dera...@openbsd.org) on 2021.01.24 16:01:32 -0700: > Stua

Re: grep: add --null flag

2021-01-26 Thread Jordan Geoghegan
On 1/26/21 5:47 AM, Stuart Henderson wrote: > On 2021/01/25 00:53, Sebastian Benoit wrote: >> Sebastian Benoit(be...@openbsd.org) on 2021.01.25 00:27:05 +0100: >>> Theo de Raadt(dera...@openbsd.org) on 2021.01.24 16:01:32 -0700: Stuart Henderson wrote: > On 2021/01/24 12:10, Theo

Re: grep: add --null flag

2021-01-26 Thread Stuart Henderson
On 2021/01/25 00:53, Sebastian Benoit wrote: > Sebastian Benoit(be...@openbsd.org) on 2021.01.25 00:27:05 +0100: > > Theo de Raadt(dera...@openbsd.org) on 2021.01.24 16:01:32 -0700: > > > Stuart Henderson wrote: > > > > > > > On 2021/01/24 12:10, Theo de Raadt wrote: > > > > > I completely despis

Re: grep: add --null flag

2021-01-25 Thread Jordan Geoghegan
On 1/24/21 3:53 PM, Sebastian Benoit wrote: > And we already have -z for "force grep to behave as zgrep". Maybe I'm misunderstanding what you're saying, but '-Z' (uppercase) appears to be the flag for "Force grep to behave as zgrep." The '-z' (lowercase) is currently unused/invalid in our gre

Re: grep: add --null flag

2021-01-25 Thread Omar Polo
Sorry for the delay, it was night in my timezone. Sebastian Benoit writes: > Sebastian Benoit(be...@openbsd.org) on 2021.01.25 00:27:05 +0100: >> Theo de Raadt(dera...@openbsd.org) on 2021.01.24 16:01:32 -0700: >> > Stuart Henderson wrote: >> > >> > > On 2021/01/24 12:10, Theo de Raadt wrote

Re: grep: add --null flag

2021-01-24 Thread Ted Unangst
On 2021-01-25, Sebastian Benoit wrote: > Sebastian Benoit(be...@openbsd.org) on 2021.01.25 00:27:05 +0100: > > Theo de Raadt(dera...@openbsd.org) on 2021.01.24 16:01:32 -0700: > > > Stuart Henderson wrote: > > > > > > > On 2021/01/24 12:10, Theo de Raadt wrote: > > > > > I completely despise that

Re: grep: add --null flag

2021-01-24 Thread Sebastian Benoit
Sebastian Benoit(be...@openbsd.org) on 2021.01.25 00:27:05 +0100: > Theo de Raadt(dera...@openbsd.org) on 2021.01.24 16:01:32 -0700: > > Stuart Henderson wrote: > > > > > On 2021/01/24 12:10, Theo de Raadt wrote: > > > > I completely despise that the option is called "--null". > > > > > > > > So

Re: grep: add --null flag

2021-01-24 Thread Sebastian Benoit
Theo de Raadt(dera...@openbsd.org) on 2021.01.24 16:01:32 -0700: > Stuart Henderson wrote: > > > On 2021/01/24 12:10, Theo de Raadt wrote: > > > I completely despise that the option is called "--null". > > > > > > Someone was a complete idiot. > > > > gnu grep has both --null and -z for this (w

Re: grep: add --null flag

2021-01-24 Thread Theo de Raadt
Stuart Henderson wrote: > On 2021/01/24 12:10, Theo de Raadt wrote: > > I completely despise that the option is called "--null". > > > > Someone was a complete idiot. > > gnu grep has both --null and -z for this (why do they do that?!). > If it's added as --null it should be added as -z too. >

Re: grep: add --null flag

2021-01-24 Thread Stuart Henderson
On 2021/01/24 12:10, Theo de Raadt wrote: > I completely despise that the option is called "--null". > > Someone was a complete idiot. gnu grep has both --null and -z for this (why do they do that?!). If it's added as --null it should be added as -z too. Looking at Debian codesearch most things

Re: grep: add --null flag

2021-01-24 Thread Theo de Raadt
I completely despise that the option is called "--null". Someone was a complete idiot. Ted Unangst wrote: > On 2021-01-22, Omar Polo wrote: > > > > quasi three-weekly ping. > > > > Is this such a bad idea? > > This seems reasonable. I think there's no need to change print line calls > thoug

Re: grep: add --null flag

2021-01-24 Thread Ted Unangst
On 2021-01-22, Omar Polo wrote: > > quasi three-weekly ping. > > Is this such a bad idea? This seems reasonable. I think there's no need to change print line calls though, just patch the implementation once. > > (TBH: I have still to look at how to write a regression test for this) > > Omar

Re: grep: add --null flag

2021-01-24 Thread Sebastian Benoit
Hi, the diff looks good, i would change the wording in the manpage a bit, see below. Anyone else who wants to ok it? /Benno Omar Polo(o...@omarpolo.com) on 2021.01.22 12:19:08 +0100: > > quasi three-weekly ping. > > Is this such a bad idea? > > (TBH: I have still to look at how to write a

Re: grep: add --null flag

2021-01-22 Thread Omar Polo
quasi three-weekly ping. Is this such a bad idea? (TBH: I have still to look at how to write a regression test for this) Omar Polo writes: > Hello, > > There are various program, especially the one written with GNU grep in > mind, that expects various flags that grep in base doesn't have. W

grep: add --null flag

2021-01-04 Thread Omar Polo
Hello, There are various program, especially the one written with GNU grep in mind, that expects various flags that grep in base doesn't have. While some of the flags (like --color) can be easily worked out (i.e. by patching/customising these programs) one thing that it isn't easily workable is -