Re: fusefs_readdir() should set eofflag

2015-02-19 Thread Martin Natano
> > @@ -733,6 +734,9 @@ > > > > fb_delete(fbuf); > > } > > + > > + if (!error && ap->a_eofflag != NULL) > > + *ap->a_eofflag = eofflag; > > Is the null check here necessary? Other file systems don't do this, so I'm > wondering if you encountered a null pointer here. I

Re: fusefs_readdir() should set eofflag

2015-02-19 Thread Ted Unangst
Martin Natano wrote: > fuse_readdir() fails to set the eofflag correctly. The consequence of > this is, that callers of VOP_READDIR, that examine the value of the > eofflag after the call, might be mislead about the eof status, as the > flag hasn't been modified (and my even be uninitialized). > >

fusefs_readdir() should set eofflag

2015-02-18 Thread Martin Natano
fuse_readdir() fails to set the eofflag correctly. The consequence of this is, that callers of VOP_READDIR, that examine the value of the eofflag after the call, might be mislead about the eof status, as the flag hasn't been modified (and my even be uninitialized). The manual page for VOP_READDIR(