On Wed, 19 Nov 2014 20:30:04 -0800, Philip Guenther wrote:
> Committed, which leads to the next diff: use O_CLOEXEC on all internal
> fds, O_DIRECTORY when opening a directory other than ".", and drop the 3rd
> argument to open() as unnecessary when O_CREAT isn't used.
Looks good to me. OK mil
On Wed, 19 Nov 2014, enh wrote:
> On Tue, Nov 18, 2014 at 10:55 PM, Philip Guenther wrote:
> > enh, this look as good in the perf measurement cited in that googlesource
> > link?
>
> yes. performance seems roughly identical. thanks!
Committed, which leads to the next diff: use O_CLOEXEC on all i
I was considering doing something like this was but was unsure about
interactions with FTS_LOGICAL (and thus FTS_NOCHDIR). I suppose
since fts_name is effectively d_name this is OK.
I also prefer passing dirp directly so the caller doesn't need to
use dirfd itself but that's not a big deal.
- t
On Tue, 18 Nov 2014, Todd C. Miller wrote:
> On Tue, 18 Nov 2014 15:19:50 +0100, Martin Pieuchot wrote:
>
> > Here's the diff inline to facilitate review:
>
> Thank you, I was having trouble navigating the web version to find
> a unified diff.
>
> The diff looks good to me. I took a stab at usi
On Tue, 18 Nov 2014 15:19:50 +0100, Martin Pieuchot wrote:
> Here's the diff inline to facilitate review:
Thank you, I was having trouble navigating the web version to find
a unified diff.
The diff looks good to me. I took a stab at using fstatat() instead
of the existing lstat() to avoid the e
On 17/11/14(Mon) 17:00, enh wrote:
> Sony sent us (Android) a patch to use fstatat instead of lstat in fts.
> Sadly our copy of fts.c is already a little diverged from yours
> (because we have to use strlen to get the length of the d_name, not
> having a d_namlen field) but i thought i'd forward th
