Re: ftp mput recursiv upload diff for testing

2012-10-12 Thread Christiano F. Haesbaert
ok haesbaert, sorry for the slacking :=). On Sat, Aug 11, 2012 at 05:48:13PM +0200, Alexander Bluhm wrote: > On Mon, Jul 30, 2012 at 10:30:47AM +0200, Jan Klemkow wrote: > > Hopefully the final version. > > Yes, I think this is OK now. If anybody else could have a look at > it, I will commit it.

Re: ftp mput recursiv upload diff for testing

2012-08-11 Thread Alexander Bluhm
On Mon, Jul 30, 2012 at 10:30:47AM +0200, Jan Klemkow wrote: > Hopefully the final version. Yes, I think this is OK now. If anybody else could have a look at it, I will commit it. bluhm > > Index: cmds.c > === > RCS file: /cvs/src

Re: ftp mput recursiv upload diff for testing

2012-07-30 Thread Jan Klemkow
Hopefully the final version. Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v retrieving revision 1.70 diff -u -p -r1.70 cmds.c --- cmds.c 5 May 2009 19:35:30 - 1.70 +++ cmds.c 30 Jul 2012 07:58:16 - @

Re: ftp mput recursiv upload diff for testing

2012-07-28 Thread Alexander Bluhm
On Sat, Jul 28, 2012 at 10:02:05PM +0200, Jan Klemkow wrote: > + if (stat(*cpp, &filestat) != 0) { > + warn(NULL); warn("local: %s", *cpp); So the user can see which file causes trouble. > + continue; > +

Re: ftp mput recursiv upload diff for testing

2012-07-28 Thread Jan Klemkow
I fixed a few things from the mails bevor... Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v retrieving revision 1.70 diff -u -p -r1.70 cmds.c --- cmds.c 5 May 2009 19:35:30 - 1.70 +++ cmds.c 28 Jul 2012

Re: ftp mput recursiv upload diff for testing

2012-07-23 Thread Jan Klemkow
Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v retrieving revision 1.70 diff -u -p -r1.70 cmds.c --- cmds.c 5 May 2009 19:35:30 - 1.70 +++ cmds.c 23 Jul 2012 18:49:30 - @@ -231,15 +231,32 @@ mput(int

Re: ftp mput recursiv upload diff for testing

2012-07-17 Thread Alexander Bluhm
On Sun, Jul 15, 2012 at 02:54:31PM +0200, Jan Klemkow wrote: > + if (!mflag) > + continue; > + if (depth == max_depth) > + continue; This breaks the non recursive case. There depth and max_depth are al

Re: ftp mput recursiv upload diff for testing

2012-07-15 Thread Jan Klemkow
Now it is, much more like mput(). I just add some error messages for the local and remote chdir/cd funktions. I So that the user has a chance to detect an error. bye, Jan Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v ret

Re: ftp mput recursiv upload diff for testing

2012-07-13 Thread Otto Moerbeek
On Fri, Jul 13, 2012 at 06:58:48PM +0200, Alexander Bluhm wrote: > On Fri, Jul 13, 2012 at 03:23:26AM +0200, Jan Klemkow wrote: > > > + char *cmd, *tp, *xargv[] = {argv[0], NULL, NULL}; > Put spaces inside {}: { argv[0], NULL, NULL } > > > It took me a while to figure out what that code d

Re: ftp mput recursiv upload diff for testing

2012-07-13 Thread Alexander Bluhm
On Fri, Jul 13, 2012 at 03:23:26AM +0200, Jan Klemkow wrote: > + char *cmd, *tp, *xargv[] = {argv[0], NULL, NULL}; Put spaces inside {}: { argv[0], NULL, NULL } > It took me a while to figure out what that code does, so I think the > comments are usefull for everybody who tries to read it.

Re: ftp mput recursiv upload diff for testing

2012-07-12 Thread Jan Klemkow
I fixed the most things. It took me a while to figure out what that code does, so I think the comments are usefull for everybody who tries to read it. The file type information comes from this special remglob2() function. There is no equivalent thing in the context of mput(). So I check the loca

Re: ftp mput recursiv upload diff for testing

2012-07-12 Thread Alexander Bluhm
Comments inline: On Mon, Jul 09, 2012 at 02:04:27PM +0200, Jan Klemkow wrote: > Index: cmds.c > === > RCS file: /cvs/src/usr.bin/ftp/cmds.c,v > retrieving revision 1.70 > diff -u -p -r1.70 cmds.c > --- cmds.c5 May 2009 19:35:30 -0

Re: ftp mput recursiv upload diff for testing

2012-07-09 Thread Jan Klemkow
On Mon, Jul 09, 2012 at 02:00:11PM +0200, Jan Klemkow wrote: > Hello, > > this is the same diff, but the mapage part it adaptet, for the current > version of ftp.1 in cvs. > > bye, > Jan > > On Thu, Jan 26, 2012 at 09:44:45PM +0100, Jan Klemkow wrote: > > On Thu, Jan 12, 2012 at 09:40:19PM +0100

Re: ftp mput recursiv upload diff for testing

2012-07-09 Thread Jan Klemkow
Hello, this is the same diff, but the mapage part it adaptet, for the current version of ftp.1 in cvs. bye, Jan On Thu, Jan 26, 2012 at 09:44:45PM +0100, Jan Klemkow wrote: > On Thu, Jan 12, 2012 at 09:40:19PM +0100, Jan Klemkow wrote: > > Hello, > > > > this is my diff for recursive upload for

Re: ftp mput recursiv upload diff for testing

2012-01-26 Thread Jan Klemkow
On Thu, Jan 12, 2012 at 09:40:19PM +0100, Jan Klemkow wrote: > Hello, > > this is my diff for recursive upload for ftp(1). > It modifies the mput command for doing this. > Please test it and tell me everything that is > wrong with it. > > bye, > Jan > I test this patch on OpenBSD 5.0 sparc64. M

ftp mput recursiv upload diff for testing

2012-01-12 Thread Jan Klemkow
Hello, this is my diff for recursive upload for ftp(1). It modifies the mput command for doing this. Please test it and tell me everything that is wrong with it. bye, Jan Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v re