Re: fread optimization

2015-01-21 Thread Theo de Raadt
> > +#define MINIMUM(a, b) (((a) < (b)) ? (a) : (b)) > > you don't want to use the MIN from ? many files in libc > already do. (though admittedly fvwrite.c defines its own, but that > seems like a bug.) I guess you haven't observed the commits of the last week... I am certain you know creates

Re: fread optimization

2015-01-21 Thread Loganaden Velvindron
On Wed, Jan 21, 2015 at 5:42 PM, enh wrote: > On Wed, Jan 21, 2015 at 3:04 AM, Martin Pieuchot > wrote: >> Hello Elliott, >> >> On 20/01/15(Tue) 16:15, enh wrote: >>> that patch wasn't setting the _flags right on error or eof. >> >> Thanks! Below is a version of your diff with some tweaks to ma

Re: fread optimization

2015-01-21 Thread Ted Unangst
On Wed, Jan 21, 2015 at 12:04, Martin Pieuchot wrote: > Hello Elliott, > > On 20/01/15(Tue) 16:15, enh wrote: >> that patch wasn't setting the _flags right on error or eof. > > Thanks! Below is a version of your diff with some tweaks to match the > recent changes done in -current. fwiw, I think

Re: fread optimization

2015-01-21 Thread Martin Pieuchot
Hello Elliott, On 20/01/15(Tue) 16:15, enh wrote: > that patch wasn't setting the _flags right on error or eof. Thanks! Below is a version of your diff with some tweaks to match the recent changes done in -current. In your original post you've shown some test numbers. Does it mean that you hav