Re: fix tcpdump localtime caching

2019-05-11 Thread Holger Mikolon
> The variables could have more meaningful names, also the reuse of > variable "gt" looks hackish, but the current code looks correct to me. > > Does the diff below make things clearer? It does. After reading the current code again a few times, it is as well clear. Incredible how I couldn't see i

Re: fix tcpdump localtime caching

2019-05-11 Thread Otto Moerbeek
On Fri, May 10, 2019 at 03:25:17PM +0200, Holger Mikolon wrote: > The comment above priv_localtime() says, the obtained localtime (from the > privileged process) is cached for about one minute. However, since the > according if statement compares the wrong variable, the caching doesn't > happen

Re: fix tcpdump localtime caching

2019-05-11 Thread Jeremie Courreges-Anglas
On Fri, May 10 2019, Holger Mikolon wrote: > The comment above priv_localtime() says, the obtained localtime (from the > privileged process) is cached for about one minute. However, since the > according if statement compares the wrong variable, the caching doesn't > happen. This bug is there s

fix tcpdump localtime caching

2019-05-10 Thread Holger Mikolon
The comment above priv_localtime() says, the obtained localtime (from the privileged process) is cached for about one minute. However, since the according if statement compares the wrong variable, the caching doesn't happen. This bug is there since the very first file version (from 15+ years ag