Re: filedesc's locking.

2017-11-28 Thread Martin Pieuchot
On 27/11/17(Mon) 19:32, Mathieu - wrote: > Martin Pieuchot wrote: > > On 27/11/17(Mon) 11:49, Mathieu - wrote: > > > Hi everyone, > > > > > > I was looking / poking around the filedesc handling in kern_descrip.c > > > and found the locking a bit.. weird, > > > > Can you define "weird"? Is it a t

Re: filedesc's locking.

2017-11-27 Thread Martin Pieuchot
On 27/11/17(Mon) 11:49, Mathieu - wrote: > Hi everyone, > > I was looking / poking around the filedesc handling in kern_descrip.c > and found the locking a bit.. weird, Can you define "weird"? Is it a taste thing or did you find any bug? If it's a bug how can you reproduce it? >

filedesc's locking.

2017-11-27 Thread Mathieu -
Hi everyone, I was looking / poking around the filedesc handling in kern_descrip.c and found the locking a bit.. weird, especially the fd_getfile function is touching protected members of the filedesc w/o taking any lock. This has been already hit previously in [1] and fixed by reordering the mall