Re: fdisk geom fixes

2011-07-04 Thread Kenneth R Westerback
On Tue, Jul 05, 2011 at 12:28:38AM -0430, Andres Perera wrote: > On Mon, Jul 4, 2011 at 11:32 PM, Kenneth R Westerback > wrote: > > On Mon, Jul 04, 2011 at 09:38:37PM -0430, Andres Perera wrote: > >> On Mon, Jul 4, 2011 at 8:56 PM, Kenneth R Westerback > >> wrote: > >> > The use of CHS should be

Re: fdisk geom fixes

2011-07-04 Thread Andres Perera
On Mon, Jul 4, 2011 at 11:32 PM, Kenneth R Westerback wrote: > On Mon, Jul 04, 2011 at 09:38:37PM -0430, Andres Perera wrote: >> On Mon, Jul 4, 2011 at 8:56 PM, Kenneth R Westerback >> wrote: >> > The use of CHS should be hard and attempted only by >> > those who know all the rules already. >> >>

Re: fdisk geom fixes

2011-07-04 Thread Andres Perera
On Mon, Jul 4, 2011 at 8:56 PM, Kenneth R Westerback wrote: > The use of CHS should be hard and attempted only by > those who know all the rules already. which is made difficult by not being able to select a subset of cyls, since fdisk caps them at 1024 on amd64 note that geom was, and continues

Re: fdisk geom fixes

2011-07-04 Thread Kenneth R Westerback
On Mon, Jul 04, 2011 at 07:59:41PM -0430, Andres Perera wrote: > On Mon, Jul 4, 2011 at 7:31 PM, Kenneth R Westerback > wrote: > > On Mon, Jul 04, 2011 at 02:26:42PM -0700, andre...@zoho.com wrote: > >> cmd.c: > >> > >> x86* maxhead should be 255, not 256 > >> > >> make geom less useless by using

Re: fdisk geom fixes

2011-07-04 Thread Andres Perera
On Mon, Jul 4, 2011 at 7:31 PM, Kenneth R Westerback wrote: > On Mon, Jul 04, 2011 at 02:26:42PM -0700, andre...@zoho.com wrote: >> cmd.c: >> >> x86* maxhead should be 255, not 256 >> >> make geom less useless by using disklabel for cyl, if available > > geom is useless, period. Making it easier w

Re: fdisk geom fixes

2011-07-04 Thread Kenneth R Westerback
On Mon, Jul 04, 2011 at 02:26:42PM -0700, andre...@zoho.com wrote: > cmd.c: > > x86* maxhead should be 255, not 256 > > make geom less useless by using disklabel for cyl, if available geom is useless, period. Making it easier will only encourage people to use it. > > part.c: > > x86* maxhead

fdisk geom fixes

2011-07-04 Thread andres . p
cmd.c: x86* maxhead should be 255, not 256 make geom less useless by using disklabel for cyl, if available part.c: x86* maxhead should be 254, not 255 (other arches?) maxcyl gets set to 1023 before this function gets called, so it's a redundant check Index: src/sbin/fdisk/cmd.c ==