Re: extern int optreset not needed

2020-12-27 Thread Theo de Raadt
Take note this change is fine for modern POSIX systems, but there are earlier systems where unistd.h did not contain these externs. That is why these externs were placed. As such, this change makes the software less portable against such ancient systems. At this point, I'm fine with that. Jan

Re: extern int optreset not needed

2020-12-27 Thread Jan Stary
On Dec 26 23:24:57, h...@stare.cz wrote: > ftpd doesn't need to declare extern int optreset > as that is already done in the included unistd.h Here's more for usr.sbin/, if desirable. Jan Index: usr.sbin//amd/amd/get_args.c ===

Re: extern int optreset not needed

2020-12-27 Thread Martijn van Duren
OK martijn@ On Sat, 2020-12-26 at 23:24 +0100, Jan Stary wrote: > ftpd doesn't need to declare extern int optreset > as that is already done in the included unistd.h > > Jan > > Index: popen.c > === > RCS file: /cvs/src/libe

extern int optreset not needed

2020-12-26 Thread Jan Stary
ftpd doesn't need to declare extern int optreset as that is already done in the included unistd.h Jan Index: popen.c === RCS file: /cvs/src/libexec/ftpd/popen.c,v retrieving revision 1.29 diff -u -p -r1.29 popen.c --- popen.c