Re: explicit_bzero after readpassphrase

2017-05-02 Thread Ricardo Mestre
As both of you said, some of these will not benefit much since it happens near the end, nevertheless it's the safe (and easy) idiom we have for "wipe this sensitive data out of memory". My main beef is that their current code might get copied by someone elsewhere to a bad place with undesired effec

Re: explicit_bzero after readpassphrase

2017-05-01 Thread Theo de Raadt
> On Mon, May 01, 2017 at 04:07:27PM -0600, Theo de Raadt wrote: > > > > Let me stop here and ask if the pattern is: "always explicit_bzero > > a password field once it is used"? It might make sense, but some > > of these are heading straight to exit immediately. Is it too much > > to do it then

Re: explicit_bzero after readpassphrase

2017-05-01 Thread Bob Beck
On Mon, May 01, 2017 at 04:07:27PM -0600, Theo de Raadt wrote: > > Let me stop here and ask if the pattern is: "always explicit_bzero > a password field once it is used"? It might make sense, but some > of these are heading straight to exit immediately. Is it too much > to do it then, or is the

Re: explicit_bzero after readpassphrase

2017-05-01 Thread Theo de Raadt
> Index: sbin/init/init.c > === > RCS file: /cvs/src/sbin/init/init.c,v > retrieving revision 1.63 > diff -u -p -u -r1.63 init.c > --- sbin/init/init.c 2 Mar 2017 10:38:09 - 1.63 > +++ sbin/init/init.c 4 Apr 2017 08:50:53 -

explicit_bzero after readpassphrase

2017-05-01 Thread Ricardo Mestre
Hi tech@, After we are done with sensitive data (such as passwords) on readpassphrase(3) we should dispose it with explicit_bzero(3), nevertheless some base applications still rely either on bzero(3), memset(3), or something else entirely. Please find a diff below to change it to explicit_bzero(3