Re: efiboot boot path matching

2017-07-31 Thread Mark Kettenis
> Date: Mon, 31 Jul 2017 20:35:45 +1000 > From: Jonathan Gray > > On Sun, Jul 30, 2017 at 11:01:58PM +0200, Mark Kettenis wrote: > > > Date: Sun, 30 Jul 2017 12:20:27 +1000 > > > From: Jonathan Gray > > > > > > On Sat, Jul 29, 2017 at 09:01:35PM +0200, Patrick Wildt wrote: > > > > On Sat, Jul 2

Re: efiboot boot path matching

2017-07-31 Thread Jonathan Gray
On Sun, Jul 30, 2017 at 11:01:58PM +0200, Mark Kettenis wrote: > > Date: Sun, 30 Jul 2017 12:20:27 +1000 > > From: Jonathan Gray > > > > On Sat, Jul 29, 2017 at 09:01:35PM +0200, Patrick Wildt wrote: > > > On Sat, Jul 29, 2017 at 02:59:19PM +0200, Mark Kettenis wrote: > > > > This is apparently v

Re: efiboot boot path matching

2017-07-30 Thread Mark Kettenis
> Date: Sun, 30 Jul 2017 12:20:27 +1000 > From: Jonathan Gray > > On Sat, Jul 29, 2017 at 09:01:35PM +0200, Patrick Wildt wrote: > > On Sat, Jul 29, 2017 at 02:59:19PM +0200, Mark Kettenis wrote: > > > This is apparently very hard. Caught this on arm64 where > > > efi_device_path_depth() returne

Re: efiboot boot path matching

2017-07-30 Thread YASUOKA Masahiko
Hi, On Sun, 30 Jul 2017 12:20:27 +1000 Jonathan Gray wrote: > On Sat, Jul 29, 2017 at 09:01:35PM +0200, Patrick Wildt wrote: >> On Sat, Jul 29, 2017 at 02:59:19PM +0200, Mark Kettenis wrote: >> > This is apparently very hard. Caught this on arm64 where >> > efi_device_path_depth() returned 0, wh

Re: efiboot boot path matching

2017-07-29 Thread Jonathan Gray
On Sat, Jul 29, 2017 at 09:01:35PM +0200, Patrick Wildt wrote: > On Sat, Jul 29, 2017 at 02:59:19PM +0200, Mark Kettenis wrote: > > This is apparently very hard. Caught this on arm64 where > > efi_device_path_depth() returned 0, which resulted in always selecting > > the first device. Clearly if

Re: efiboot boot path matching

2017-07-29 Thread Patrick Wildt
On Sat, Jul 29, 2017 at 02:59:19PM +0200, Mark Kettenis wrote: > This is apparently very hard. Caught this on arm64 where > efi_device_path_depth() returned 0, which resulted in always selecting > the first device. Clearly if the first path component (i = 0) matches > the desired type, we should

efiboot boot path matching

2017-07-29 Thread Mark Kettenis
This is apparently very hard. Caught this on arm64 where efi_device_path_depth() returned 0, which resulted in always selecting the first device. Clearly if the first path component (i = 0) matches the desired type, we should return 1, not 0. Here is the amd64 version of the diff which is easier