Re: eeprom does not compile on current/macppc

2016-01-01 Thread a . velichinsky
On Thu, Dec 31, 2015 at 12:01:10PM -0700, Todd C. Miller wrote: > Hmmm, should the yyparse() proto really be static? The actual > yyparse() generated by yacc is not static. the yyparse() as generated by yacc may be either static or extern depending on the user's preference -- she's free to declar

Re: eeprom does not compile on current/macppc

2015-12-31 Thread Todd C. Miller
On Thu, 31 Dec 2015 11:23:19 -0800, Philip Guenther wrote: > Putting it in the header[] array appears to generate good output, even > with the -p option. OK millert@, works fine with and without -p. - todd

Re: eeprom does not compile on current/macppc

2015-12-31 Thread Mark Kettenis
> From: "Todd C. Miller" > Date: Thu, 31 Dec 2015 12:13:05 -0700 > > On Thu, 31 Dec 2015 11:02:01 -0800, Philip Guenther wrote: > > > Wouldn't it better to have yacc's skeleton.c provide a prototype so > > that it's fixed for all .y files? I see that bison's output includes > > an "int yyparse

Re: eeprom does not compile on current/macppc

2015-12-31 Thread Philip Guenther
On Thu, Dec 31, 2015 at 11:13 AM, Todd C. Miller wrote: > On Thu, 31 Dec 2015 11:02:01 -0800, Philip Guenther wrote: > >> Wouldn't it better to have yacc's skeleton.c provide a prototype so >> that it's fixed for all .y files? I see that bison's output includes >> an "int yyparse (void);" prototy

Re: eeprom does not compile on current/macppc

2015-12-31 Thread Mark Kettenis
> From: "Todd C. Miller" > Date: Thu, 31 Dec 2015 12:01:10 -0700 > > On Thu, 31 Dec 2015 19:53:01 +0100, Mark Kettenis wrote: > > > Fallout from -Werror-implicit-function-declaration. > > > > Diff below fixes it. ok? > > Hmmm, should the yyparse() proto really be static? The actual > yyparse

Re: eeprom does not compile on current/macppc

2015-12-31 Thread Todd C. Miller
On Thu, 31 Dec 2015 11:02:01 -0800, Philip Guenther wrote: > Wouldn't it better to have yacc's skeleton.c provide a prototype so > that it's fixed for all .y files? I see that bison's output includes > an "int yyparse (void);" prototype, so I would expect minimal ports > issues. That's probably

Re: eeprom does not compile on current/macppc

2015-12-31 Thread Todd C. Miller
On Thu, 31 Dec 2015 19:53:01 +0100, Mark Kettenis wrote: > Fallout from -Werror-implicit-function-declaration. > > Diff below fixes it. ok? Hmmm, should the yyparse() proto really be static? The actual yyparse() generated by yacc is not static. - todd

Re: eeprom does not compile on current/macppc

2015-12-31 Thread Mark Kettenis
> Date: Thu, 31 Dec 2015 13:18:13 +0100 > From: Jan Stary > > ===> usr.sbin/eeprom > cc -O2 -pipe -Werror-implicit-function-declaration -c getdate.c > /usr/src/usr.sbin/eeprom/getdate.y: In function 'get_date': > /usr/src/usr.sbin/eeprom/getdate.y:860: error: implicit declaration of > function

Re: eeprom does not compile on current/macppc

2015-12-31 Thread Todd C. Miller
On Thu, 31 Dec 2015 19:53:01 +0100, Mark Kettenis wrote: > Fallout from -Werror-implicit-function-declaration. > > Diff below fixes it. ok? OK millert@ - todd

Re: eeprom does not compile on current/macppc

2015-12-31 Thread Philip Guenther
On Thu, Dec 31, 2015 at 10:53 AM, Mark Kettenis wrote: >> Date: Thu, 31 Dec 2015 13:18:13 +0100 >> From: Jan Stary >> >> ===> usr.sbin/eeprom >> cc -O2 -pipe -Werror-implicit-function-declaration -c getdate.c >> /usr/src/usr.sbin/eeprom/getdate.y: In function 'get_date': >> /usr/src/usr.sbin/ee

eeprom does not compile on current/macppc

2015-12-31 Thread Jan Stary
Rebuilding the userland on a current/maccppc MacMini filas with ===> usr.sbin/eeprom cc -O2 -pipe -Werror-implicit-function-declaration -c getdate.c /usr/src/usr.sbin/eeprom/getdate.y: In function 'get_date': /usr/src/usr.sbin/eeprom/getdate.y:860: error: implicit declaration of function 'yypars