Re: dovutimens(): call vput() on error

2016-06-26 Thread Sebastien Marie
On Sun, Jun 26, 2016 at 12:37:57PM -0700, Philip Guenther wrote: > On Sun, Jun 26, 2016 at 9:09 AM, Sebastien Marie wrote: > > In the following code, namei() call is done in doutimensat(), and > > nd.ni_vp is passed to dovutimens() as vp. > > > > In the same way, in dofutimens() the vp (from getvn

Re: dovutimens(): call vput() on error

2016-06-26 Thread Philip Guenther
On Sun, Jun 26, 2016 at 9:09 AM, Sebastien Marie wrote: > In the following code, namei() call is done in doutimensat(), and > nd.ni_vp is passed to dovutimens() as vp. > > In the same way, in dofutimens() the vp (from getvnode) is vref() before > calling dovutimens(). > > So I think we should call

dovutimens(): call vput() on error

2016-06-26 Thread Sebastien Marie
Hi, In the following code, namei() call is done in doutimensat(), and nd.ni_vp is passed to dovutimens() as vp. In the same way, in dofutimens() the vp (from getvnode) is vref() before calling dovutimens(). So I think we should call vput() before returning any error. -- Sebastien Marie Index: