Re: disable PPP_BSDCOMP by default

2021-03-30 Thread Balder Oddson
On Tue, Mar 30, 2021 at 12:00:10AM +0200, Balder Oddson wrote: > On Thu, Mar 25, 2021 at 12:46:24PM -0600, Theo de Raadt wrote: > > No way for this diff. This is the wrong way. Surely there are ways > > to disable compression negotion on specific sessions, but removing > > the code from the kerne

Re: disable PPP_BSDCOMP by default

2021-03-29 Thread Balder Oddson
On Thu, Mar 25, 2021 at 12:46:24PM -0600, Theo de Raadt wrote: > No way for this diff. This is the wrong way. Surely there are ways > to disable compression negotion on specific sessions, but removing > the code from the kernel is the wrong knob. So whom do I explain for feedbeef OK? You can run

Re: disable PPP_BSDCOMP by default

2021-03-26 Thread Balder Oddson
On Thu, Mar 25, 2021 at 08:46:10PM -0600, Theo de Raadt wrote: > Balder Oddson wrote: > > > On Thu, Mar 25, 2021 at 03:40:15PM -0600, Theo de Raadt wrote: > > > Stuart Henderson wrote: > > > > > > > > Not having read the code, case in point on principle, I'm arguing that > > > > > there should

Re: disable PPP_BSDCOMP by default

2021-03-25 Thread Theo de Raadt
Balder Oddson wrote: > On Thu, Mar 25, 2021 at 03:40:15PM -0600, Theo de Raadt wrote: > > Stuart Henderson wrote: > > > > > > Not having read the code, case in point on principle, I'm arguing that > > > > there should be solid reasoning to enable it by default, as those with a > > > > need for

Re: disable PPP_BSDCOMP by default

2021-03-25 Thread Balder Oddson
On Thu, Mar 25, 2021 at 03:40:15PM -0600, Theo de Raadt wrote: > Stuart Henderson wrote: > > > > Not having read the code, case in point on principle, I'm arguing that > > > there should be solid reasoning to enable it by default, as those with a > > > need for it can certainly enable it and buil

Re: disable PPP_BSDCOMP by default

2021-03-25 Thread Theo de Raadt
Stuart Henderson wrote: > > Not having read the code, case in point on principle, I'm arguing that > > there should be solid reasoning to enable it by default, as those with a > > need for it can certainly enable it and build a kernel. > > It's not that simple, using a custom kernel means you ca

Re: disable PPP_BSDCOMP by default

2021-03-25 Thread Stuart Henderson
On 2021/03/25 20:53, Balder Oddson wrote: > On Thu, Mar 25, 2021 at 07:09:37PM +0100, Balder Oddson wrote: > > Compression in PPP was great in the age of ISDN to increase speeds. > > The more common use cases, and trends concerning TLS1.3 advancements. > > > > Having this enabled by default, and i

Re: disable PPP_BSDCOMP by default

2021-03-25 Thread Balder Oddson
On Thu, Mar 25, 2021 at 07:09:37PM +0100, Balder Oddson wrote: > Compression in PPP was great in the age of ISDN to increase speeds. > The more common use cases, and trends concerning TLS1.3 advancements. > > Having this enabled by default, and infrequently used could lead to > unintended conseque

Re: disable PPP_BSDCOMP by default

2021-03-25 Thread Theo de Raadt
No way for this diff. This is the wrong way. Surely there are ways to disable compression negotion on specific sessions, but removing the code from the kernel is the wrong knob. Balder Oddson wrote: > Compression in PPP was great in the age of ISDN to increase speeds. > The more common use cas

disable PPP_BSDCOMP by default

2021-03-25 Thread Balder Oddson
Compression in PPP was great in the age of ISDN to increase speeds. The more common use cases, and trends concerning TLS1.3 advancements. Having this enabled by default, and infrequently used could lead to unintended consequences around how the data is passed around. Index: GENERIC =