Re: diff3: use boolean OR, not bitwise

2016-10-16 Thread Otto Moerbeek
On Sun, Oct 16, 2016 at 08:44:34AM -0600, Todd C. Miller wrote: > On Sun, 16 Oct 2016 16:06:39 +0200, Otto Moerbeek wrote: > > > On Sun, Oct 16, 2016 at 07:07:36AM -0600, Todd C. Miller wrote: > > > > > It is effectively the same in this case but using the boolean OR > > > is less surprising and

Re: diff3: use boolean OR, not bitwise

2016-10-16 Thread Todd C. Miller
On Sun, 16 Oct 2016 16:06:39 +0200, Otto Moerbeek wrote: > On Sun, Oct 16, 2016 at 07:07:36AM -0600, Todd C. Miller wrote: > > > It is effectively the same in this case but using the boolean OR > > is less surprising and may quiet over zealous compilers. > > Are you sure? For example, in cvs/dif

Re: diff3: use boolean OR, not bitwise

2016-10-16 Thread Otto Moerbeek
On Sun, Oct 16, 2016 at 07:07:36AM -0600, Todd C. Miller wrote: > It is effectively the same in this case but using the boolean OR > is less surprising and may quiet over zealous compilers. Are you sure? For example, in cvs/diff3.c t2 is not always initialized with this change. -Otto >

diff3: use boolean OR, not bitwise

2016-10-16 Thread Todd C. Miller
It is effectively the same in this case but using the boolean OR is less surprising and may quiet over zealous compilers. OK? - todd Index: cvs/diff3.c === RCS file: /cvs/src/usr.bin/cvs/diff3.c,v retrieving revision 1.61 diff -u -