On Sunday, April 25, Brad wrote:
> On Sat, Apr 24, 2010 at 08:52:25PM -0700, Philip Guenther wrote:
> > On Sat, Apr 24, 2010 at 1:33 PM, Brad wrote:
> > ...
> > > I have updated the diff with your suggestions.
> >
> > Close: I think the #include of needs to be moved up in
> > sys/mman.h so that
On Sat, Apr 24, 2010 at 08:52:25PM -0700, Philip Guenther wrote:
> On Sat, Apr 24, 2010 at 1:33 PM, Brad wrote:
> ...
> > I have updated the diff with your suggestions.
>
> Close: I think the #include of needs to be moved up in
> sys/mman.h so that the __BSD_VISIBLE test actually works. Otherwi
On Sat, Apr 24, 2010 at 1:33 PM, Brad wrote:
...
> I have updated the diff with your suggestions.
Close: I think the #include of needs to be moved up in
sys/mman.h so that the __BSD_VISIBLE test actually works. Otherwise,
looks good to me.
Philip Guenther
On Sat, Apr 24, 2010 at 4:33 PM, Brad wrote:
>> 4) implement posix_madvise() as a call to _thread_sys_madvise()
>>instead of madvise()
>
> Why this last one?
If a program implements its own madvise, calling posix_madvise should
do the right thing (not call the program's version). I'll look c
On Wed, Apr 21, 2010 at 09:36:45PM -0700, Philip Guenther wrote:
> On Mon, Apr 19, 2010 at 7:49 PM, Brad wrote:
> > Here is a diff to add posix_madvise() to libc.
> ...
> > -#define ? ? ? ?MADV_NORMAL ? ? 0 ? ? ? /* no further special treatment */
> ...
> > +#defi
On Mon, Apr 19, 2010 at 7:49 PM, Brad wrote:
> Here is a diff to add posix_madvise() to libc.
...
> -#defineMADV_NORMAL 0 /* no further special treatment */
...
> +#definePOSIX_MADV_NORMAL 0 /* no further special
treatment */
...
> +#define
Here is a diff to add posix_madvise() to libc.
Mostly from NetBSD.
Index: sys/sys/mman.h
===
RCS file: /cvs/src/sys/sys/mman.h,v
retrieving revision 1.18
diff -u -p -r1.18 mman.h
--- sys/sys/mman.h 21 Jul 2003 22:52:19 -
